[PATCH 2/5] dinput: Return E_NOINTERFACE from IDirectInputDevice2 QueryInterface

[Alistair Leslie-Hughes]

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
---
 dlls/dinput/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c
index 6c446163d1..cfade08433 100644
--- a/dlls/dinput/device.c
+++ b/dlls/dinput/device.c
@@ -1203,7 +1203,7 @@ HRESULT WINAPI IDirectInputDevice2WImpl_QueryInterface(LPDIRECTINPUTDEVICE8W ifa
     }
 
     WARN("Unsupported interface!\n");
-    return E_FAIL;
+    return E_NOINTERFACE;
 }
 
 HRESULT WINAPI IDirectInputDevice2AImpl_QueryInterface(LPDIRECTINPUTDEVICE8A iface, REFIID riid, LPVOID *ppobj)
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=51561

Your paranoid android.


=== debian9 (32 bit report) ===

dinput8:
Unhandled exception: page fault on read access to 0xdeadbeef in 32-bit code (0x7ecefa9c).

Report errors:
dinput8:dinput crashed (c0000005)

=== debian9 (32 bit Chinese:China report) ===

dinput8:
Unhandled exception: page fault on read access to 0xdeadbeef in 32-bit code (0x7ecefa9c).

Report errors:
dinput8:dinput crashed (c0000005)

=== debian9 (32 bit WoW report) ===

dinput8:
Unhandled exception: page fault on read access to 0xdeadbeef in 32-bit code (0x7ece2a9c).

Report errors:
dinput8:dinput crashed (c0000005)

=== debian9 (64 bit WoW report) ===

dinput8:
Unhandled exception: page fault on read access to 0xdeadbeef in 32-bit code (0x7ece2a9c).

Report errors:
dinput8:dinput crashed (c0000005)