Re: [2/2] runtest: Let the test program handle the lack of a test name.

[Rob Shearman]

2008/9/30 Dylan Smith <dylan.ah.smith(a)gmail.com>:
> -exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" "$infile" "$@"
> +exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" $infile $@

It looks like this will cause problems now if $infile contains spaces
or if any of the arguments in $@ contain spaces.

-- 
Rob Shearman

[2/2] runtest: Let the test program handle the lack of a test name.

[Dylan Smith]

On Wed, Oct 1, 2008 at 6:13 AM, Rob Shearman <robertshearman(a)gmail.com>wrote:
> 2008/9/30 Dylan Smith <dylan.ah.smith(a)gmail.com>:
> > -exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" "$infile" "$@"
> > +exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" $infile $@
>
> It looks like this will cause problems now if $infile contains spaces
> or if any of the arguments in $@ contain spaces.
>
> --
> Rob Shearman

I didn't think about that, thanks for pointing that out.

A change there does need to be made, because what happens when I run runtest
without arguments is:
Fatal: test '' does not exist.

So I do need to pass in no arguments when $infile isn't given, but that can
also be done with the following code:

if [ -z "$infile" ]; then
    exec $WINETEST_WRAPPER "$topobjdir/wine" "$program"
else
    exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" "$infile" "$@"
fi