Re: [PATCH 02/12] wined3d: store wined3d_texture and sub_resource_idx in d3dX surfaces

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2015-09-23 um 10:27 schrieb Riccardo Bortolato:
> wined3d_mutex_lock();
> +    sub_resource = wined3d_texture_get_sub_resource(bitmap_impl->wined3d_texture, bitmap_impl->sub_resource_idx);
> +    wined3d_surface = wined3d_surface_from_resource(sub_resource);
>      hr = wined3d_device_set_cursor_properties(device->wined3d_device,
> -            hotspot_x, hotspot_y, bitmap_impl->wined3d_surface);
> +            hotspot_x, hotspot_y, wined3d_surface);
>      wined3d_mutex_unlock();

You may want to consider changing wined3d_device_set_cursor_properties
to accept a wined3d_texture instead. Keep in mind though that this would
be a bit of a side quest, as you'll have to find out if native accepts
surfaces that are part of textures or just stand-alone surfaces created
by CreateImageSurface. If it is the latter (which I suspect it is) then
wined3d_texture alone is OK. Otherwise you need texture + idx.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWAmlwAAoJEN0/YqbEcdMwGlkP/RfRVsceuPRGgVE0yJvhV26U
ci6CDlrj4Lb2mFcH3IVlJKuJEOcT2TLrcx2hT3H2+0OjDBvAIJyLhzjxABaZsg0N
OU4TJCvLfPiieF0npy7EBpUoe+E8a4046DRnLJsooco1Cp+Fk2LZO4B1OjMoaexl
FaO9zoAO+3KlTNVwRKX65KnOsZB7PtP0soCS9Gsmvx1gwwVe42uQ8B5pSgQQzcgW
UablqGdE0NnUGN2Bcj6vxPdW14FEaWC7Mp8fBl8olLO/FdlEoehzUMO7bPJNgGr2
wePB12qwmTfizcQ+Nmd5/HAGZMsn4vgfxu+kQSb0iaWxdgRtqKztlkLzAOFvGDTS
x+yZ2pWTcNp41MzZI9yxRStI5eLq5ZBQ9vY64A85W3Zwj/wTb7eR6A/qWveOUYsG
6EtQ9F0pQ43hotiE9a/8AdvTlrwQ+lcK6W01Ngg2mh9xnZ8pcD1Zqugy7RYDoHiQ
u+yd0BxvV3SjmjA0h4qZRVUh/ct5UMPCp6gJdHJFtSsKfoRAq96BzI3g3AFGH+Xv
u0Tkjq7QbhtLPxdjdc8A61SbwRFqygrj3XsZi0ji6qar5tjW58u0PdRskb4NTUhu
lEYUETpysaj29ktGURJ3s5/G1TKauDM9G4jx9puM8Kh0LilKshRwIsJaZf+4uHeW
BBmwwFk8QMQpKffLOCie
=W7On
-----END PGP SIGNATURE-----

[PATCH 02/12] wined3d: store wined3d_texture and sub_resource_idx in d3dX surfaces

[Riccardo Bortolato]

The idea is to change individual api calls later as some of them are
*really* complicated (at least for me).

Ciao,
Riccardo

2015-09-23 10:57 GMT+02:00 Stefan Dösinger <stefandoesinger(a)gmail.com>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Am 2015-09-23 um 10:27 schrieb Riccardo Bortolato:
> > wined3d_mutex_lock();
> > +    sub_resource = wined3d_texture_get_sub_resource(bitmap_impl->wined3d_texture, bitmap_impl->sub_resource_idx);
> > +    wined3d_surface = wined3d_surface_from_resource(sub_resource);
> >      hr = wined3d_device_set_cursor_properties(device->wined3d_device,
> > -            hotspot_x, hotspot_y, bitmap_impl->wined3d_surface);
> > +            hotspot_x, hotspot_y, wined3d_surface);
> >      wined3d_mutex_unlock();
>
> You may want to consider changing wined3d_device_set_cursor_properties
> to accept a wined3d_texture instead. Keep in mind though that this would
> be a bit of a side quest, as you'll have to find out if native accepts
> surfaces that are part of textures or just stand-alone surfaces created
> by CreateImageSurface. If it is the latter (which I suspect it is) then
> wined3d_texture alone is OK. Otherwise you need texture + idx.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJWAmlwAAoJEN0/YqbEcdMwGlkP/RfRVsceuPRGgVE0yJvhV26U
> ci6CDlrj4Lb2mFcH3IVlJKuJEOcT2TLrcx2hT3H2+0OjDBvAIJyLhzjxABaZsg0N
> OU4TJCvLfPiieF0npy7EBpUoe+E8a4046DRnLJsooco1Cp+Fk2LZO4B1OjMoaexl
> FaO9zoAO+3KlTNVwRKX65KnOsZB7PtP0soCS9Gsmvx1gwwVe42uQ8B5pSgQQzcgW
> UablqGdE0NnUGN2Bcj6vxPdW14FEaWC7Mp8fBl8olLO/FdlEoehzUMO7bPJNgGr2
> wePB12qwmTfizcQ+Nmd5/HAGZMsn4vgfxu+kQSb0iaWxdgRtqKztlkLzAOFvGDTS
> x+yZ2pWTcNp41MzZI9yxRStI5eLq5ZBQ9vY64A85W3Zwj/wTb7eR6A/qWveOUYsG
> 6EtQ9F0pQ43hotiE9a/8AdvTlrwQ+lcK6W01Ngg2mh9xnZ8pcD1Zqugy7RYDoHiQ
> u+yd0BxvV3SjmjA0h4qZRVUh/ct5UMPCp6gJdHJFtSsKfoRAq96BzI3g3AFGH+Xv
> u0Tkjq7QbhtLPxdjdc8A61SbwRFqygrj3XsZi0ji6qar5tjW58u0PdRskb4NTUhu
> lEYUETpysaj29ktGURJ3s5/G1TKauDM9G4jx9puM8Kh0LilKshRwIsJaZf+4uHeW
> BBmwwFk8QMQpKffLOCie
> =W7On
> -----END PGP SIGNATURE-----