Re: USER32: result of ScrollBar functions review

[Dmitry Timoshkov]

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote:
> +/* New Scrollbar info since Windows 98, Windows NT 4.0 with SP6 */
> +typedef struct tagSCROLLBARINFO
> +{
> +    DWORD   cbSize;             /* Size of SCROLLBARINFO struct */
> ...
> +BOOL WINAPI GetScrollBarInfo(HWND hwnd, LONG idObject, LPSCROLLBARINFO psbi)
> +{
> +    RECT rect;
> +    INT arrowSize, thumbSize, thumbPos, nBar, vertical;
> +    FIXME("check me");
> +    if (psbi->cbSize != sizeof(RECT))
> +        return FALSE;

Why are you testing psbi->cbSize for sizeof(RECT) here?

-- 
Dmitry.

USER32: result of ScrollBar functions review

[Vitaly Lipatov]

В сообщении от 3 Январь 2005 18:23 Dmitry Timoshkov написал(a):
> > +    FIXME("check me");
> > +    if (psbi->cbSize != sizeof(RECT))
> > +        return FALSE;
>
> Why are you testing psbi->cbSize for sizeof(RECT) here?

It is my mistake. The corrected version placed below:

--- dlls/user/1/scroll.c 2005-01-02 20:42:54 +0300
+++ dlls/user/scroll.c 2005-01-03 18:40:54 +0300
@@ -1724,7 +1724,7 @@
     RECT rect;
     INT arrowSize, thumbSize, thumbPos, nBar, vertical;
     FIXME("check me");
-    if (psbi->cbSize != sizeof(RECT))
+    if (psbi->cbSize != sizeof(SCROLLBARINFO))
         return FALSE;
     switch (idObject)
     {


Will I resend the patch?

-- 
Vitaly Lipatov, ALT Linux Team
Russia, Saint-Petersburg, www.etersoft.ru