[PATCH 1/2] winhttp: Modify index only if query_headers succeeded.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
 dlls/winhttp/request.c       |  3 +--
 dlls/winhttp/tests/winhttp.c | 39 ++++++++++++++++++++++++++++++++++++++-
 2 files changed, 39 insertions(+), 3 deletions(-)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=42260

Your paranoid android.


=== w2003std (32 bit Windows report) ===

winhttp:
winhttp.c:4084: Test failed: got 80072f0d

=== wvistau64_he (32 bit Windows report) ===

winhttp:
winhttp.c:2431: Test failed: failed to receive response 12152
winhttp.c:2436: Test failed: failed to query status code 12019
winhttp.c:2437: Test failed: request failed unexpectedly 3735928559
winhttp.c:2452: Test failed: failed to query for raw headers: 12019
winhttp.c:2453: Test failed: WinHttpQueryHeaders returned invalid end of header string
winhttp.c:2459: Test failed: failed to query for raw headers: 12019
winhttp.c:2460: Test failed: WinHttpQueryHeaders returned invalid end of header string
winhttp.c:2462: Test failed: returned string has too many NULL characters
winhttp.c:2467: Test failed: failed to read data 12019
winhttp.c:2468: Test failed: count was wrong
winhttp.c:2469: Test failed: http data wrong

[Jacek Caban]

On 09/19/2018 04:58 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=42260
>
> Your paranoid android.
>
> === w2003std (32 bit Windows report) ===
>
> winhttp:
> winhttp.c:4084: Test failed: got 80072f0d
>
> === wvistau64_he (32 bit Windows report) ===
>
> winhttp:
> winhttp.c:2431: Test failed: failed to receive response 12152
> winhttp.c:2436: Test failed: failed to query status code 12019
> winhttp.c:2437: Test failed: request failed unexpectedly 3735928559
> winhttp.c:2452: Test failed: failed to query for raw headers: 12019
> winhttp.c:2453: Test failed: WinHttpQueryHeaders returned invalid end of header string
> winhttp.c:2459: Test failed: failed to query for raw headers: 12019
> winhttp.c:2460: Test failed: WinHttpQueryHeaders returned invalid end of header string
> winhttp.c:2462: Test failed: returned string has too many NULL characters
> winhttp.c:2467: Test failed: failed to read data 12019
> winhttp.c:2468: Test failed: count was wrong
> winhttp.c:2469: Test failed: http data wrong

Those are already existing failures.


Jacek

[Hans Leidekker]

Signed-off-by: Hans Leidekker <hans(a)codeweavers.com>