Re: [3/5] fusion: Assembly version numbers are WORDs.

[James Hawkins]

This definitely needs a test.

-- 
James Hawkins

On Fri, Feb 13, 2009 at 12:14 AM, Hans Leidekker <hans(a)meelstraat.net> wrote:
> diff --git a/dlls/fusion/asmname.c b/dlls/fusion/asmname.c
> index acf0411..ebf76af 100644
> --- a/dlls/fusion/asmname.c
> +++ b/dlls/fusion/asmname.c
> @@ -45,7 +45,7 @@ typedef struct {
>     LPWSTR name;
>     LPWSTR culture;
>
> -    BYTE version[4];
> +    WORD version[4];
>     DWORD versize;
>
> BYTE pubkey[8];
> @@ -145,28 +145,28 @@ static HRESULT WINAPI IAssemblyNameImpl_GetProperty(IAssemblyName *iface,
>
> case ASM_NAME_MAJOR_VERSION:
>             *pcbProperty = 0;
> -            *((LPDWORD)pvProperty) = name->version[0];
> +            *((WORD *)pvProperty) = name->version[0];
>             if (name->versize >= 1)
>                 *pcbProperty = sizeof(WORD);
>             break;
>
> case ASM_NAME_MINOR_VERSION:
>             *pcbProperty = 0;
> -            *((LPDWORD)pvProperty) = name->version[1];
> +            *((WORD *)pvProperty) = name->version[1];
>             if (name->versize >= 2)
>                 *pcbProperty = sizeof(WORD);
>             break;
>
> case ASM_NAME_BUILD_NUMBER:
>             *pcbProperty = 0;
> -            *((LPDWORD)pvProperty) = name->version[2];
> +            *((WORD *)pvProperty) = name->version[2];
>             if (name->versize >= 3)
>                 *pcbProperty = sizeof(WORD);
>             break;
>
> case ASM_NAME_REVISION_NUMBER:
>             *pcbProperty = 0;
> -            *((LPDWORD)pvProperty) = name->version[3];
> +            *((WORD *)pvProperty) = name->version[3];
>             if (name->versize >= 4)
>                 *pcbProperty = sizeof(WORD);
>             break;

[3/5] fusion: Assembly version numbers are WORDs.

[Hans Leidekker]

On Friday 13 February 2009 09:26:03 James Hawkins wrote:
> This definitely needs a test.

Patch [5/5] has a test that depends on this.

 -Hans