[PATCH 1/3] cabinet/tests: Alter string declaration to include null terminator.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=55574

Your paranoid android.


=== debian10 (32 bit report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (32 bit French report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (32 bit Japanese:Japan report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (32 bit Chinese:China report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (32 bit WoW report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (64 bit WoW report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

[Dmitry Timoshkov]

Isira Seneviratne <isirasen96(a)gmail.com> wrote:
> + * Copyright (C) 2019 Isira Seneviratne

Does this really deserve adding the copyright notice?
> *
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
> @@ -776,7 +777,7 @@ static UINT CDECL fdi_mem_read(INT_PTR hf, void *pv, UINT cb)
>
> static UINT CDECL fdi_mem_write(INT_PTR hf, void *pv, UINT cb)
>  {
> -    static const char expected[12] = "Hello World!";
> +    static const char expected[12] = { 'H','e','l','l','o','W','o','r','l','d','!','\0' };

It was deliberate choice, nohing depends on it being 0 terminated.

-- 
Dmitry.