Re: winemp3.acm: link to system libmpg123.so
Aric Stewart escribió:
--- configure.ac | 12 + dlls/winemp3.acm/Makefile.in | 11 +- dlls/winemp3.acm/common.c | 261 ------- dlls/winemp3.acm/dct64_i386.c | 329 -------- dlls/winemp3.acm/decode_i386.c | 164 ---- dlls/winemp3.acm/huffman.h | 346 --------- dlls/winemp3.acm/interface.c | 254 ------- dlls/winemp3.acm/l2tables.h | 175 ----- dlls/winemp3.acm/layer1.c | 159 ---- dlls/winemp3.acm/layer2.c | 301 -------- dlls/winemp3.acm/layer3.c | 1613 ---------------------------------------- dlls/winemp3.acm/mpegl3.c | 119 ++-- dlls/winemp3.acm/mpg123.h | 166 ---- dlls/winemp3.acm/mpglib.h | 69 -- dlls/winemp3.acm/tabinit.c | 95 --- 15 files changed, 81 insertions(+), 3993 deletions(-) delete mode 100644 dlls/winemp3.acm/common.c delete mode 100644 dlls/winemp3.acm/dct64_i386.c delete mode 100644 dlls/winemp3.acm/decode_i386.c delete mode 100644 dlls/winemp3.acm/huffman.h delete mode 100644 dlls/winemp3.acm/interface.c delete mode 100644 dlls/winemp3.acm/l2tables.h delete mode 100644 dlls/winemp3.acm/layer1.c delete mode 100644 dlls/winemp3.acm/layer2.c delete mode 100644 dlls/winemp3.acm/layer3.c delete mode 100644 dlls/winemp3.acm/mpg123.h delete mode 100644 dlls/winemp3.acm/mpglib.h delete mode 100644 dlls/winemp3.acm/tabinit.c
------------------------------------------------------------------------
The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame. -- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame.
-- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);
Recently there has been a discussion on this point and in the end it was decided to not ship our own libmpg123 but use a packaged version. Several distributions including Debian and Ubuntu ship it but opensuse and fedora don't ship mp3 and other codecs for patenting reasons. Since rpmfusion seems to host packages not provided by Fedora because of legal purposes, I think they should add libmpg123 as well. Roderick
2009/8/19 Roderick Colenbrander <thunderbird2k(a)gmail.com>:
The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame.
-- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);
Recently there has been a discussion on this point and in the end it was decided to not ship our own libmpg123 but use a packaged version. Several distributions including Debian and Ubuntu ship it but opensuse and fedora don't ship mp3 and other codecs for patenting reasons. Since rpmfusion seems to host packages not provided by Fedora because of legal purposes, I think they should add libmpg123 as well.
Roderick
What about using more popular libraries as libmad, lame or maybe gstreamer to decode mp3 files? I believe someone previously said that gstreamer is also available on Mac.
On Wed, Aug 19, 2009 at 11:26 PM, Matteo Bruni<matteo.mystral(a)gmail.com> wrote:
2009/8/19 Roderick Colenbrander <thunderbird2k(a)gmail.com>:
The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame.
-- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);
Recently there has been a discussion on this point and in the end it was decided to not ship our own libmpg123 but use a packaged version. Several distributions including Debian and Ubuntu ship it but opensuse and fedora don't ship mp3 and other codecs for patenting reasons. Since rpmfusion seems to host packages not provided by Fedora because of legal purposes, I think they should add libmpg123 as well.
Roderick
What about using more popular libraries as libmad, lame or maybe gstreamer to decode mp3 files? I believe someone previously said that gstreamer is also available on Mac.
Gstreamer could be an option as well. One of the Wine gsoc projects is about adding gstreamer support to DirectShow (quartz). It would be possible to even implement mp3 support using DirectShow.. I don't think we want to use gstreamer from two places. Adding mp3 support to gstreamer is easy e.g. download the free fluendo mp3 plugin if your distribution does not ship with it. Roderick
On Wednesday 19 August 2009 2:26:37 pm Matteo Bruni wrote:
What about using more popular libraries as libmad, lame or maybe gstreamer to decode mp3 files? I believe someone previously said that gstreamer is also available on Mac.
libmad is GPL, and IIRC lame uses libmpg123 or libmad for decoding. GStreamer seems rather hefty if you just need its mp3 decoder, IMO.
I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add it to the frameworks as well so that either libmpg123 or libmad would be able to be used. But i see this as an addition onto the libmpg123 work instead of a replacement of. -aric Chris Robinson wrote:
On Wednesday 19 August 2009 2:26:37 pm Matteo Bruni wrote:
What about using more popular libraries as libmad, lame or maybe gstreamer to decode mp3 files? I believe someone previously said that gstreamer is also available on Mac.
libmad is GPL, and IIRC lame uses libmpg123 or libmad for decoding. GStreamer seems rather hefty if you just need its mp3 decoder, IMO.
A quick license check does show that libmad is indeed GPL which means we cannot use it in WINE at all. -aric Aric Stewart wrote:
I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add it to the frameworks as well so that either libmpg123 or libmad would be able to be used.
But i see this as an addition onto the libmpg123 work instead of a replacement of.
-aric
Chris Robinson wrote:
On Wednesday 19 August 2009 2:26:37 pm Matteo Bruni wrote:
What about using more popular libraries as libmad, lame or maybe gstreamer to decode mp3 files? I believe someone previously said that gstreamer is also available on Mac.
libmad is GPL, and IIRC lame uses libmpg123 or libmad for decoding. GStreamer seems rather hefty if you just need its mp3 decoder, IMO.
If you are considering to write an additional backend, I would advise to add a fallback path to directshow. When the gstreamer code enters mp3 can then easily be added. If directshow for gstreamer isn't around, just use libmpg123 or use libmpg123 by default and directshow as a fallback. Roderick On Thu, Aug 20, 2009 at 2:38 PM, Aric Stewart<aric(a)codeweavers.com> wrote:
A quick license check does show that libmad is indeed GPL which means we cannot use it in WINE at all.
-aric
Aric Stewart wrote:
I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add it to the frameworks as well so that either libmpg123 or libmad would be able to be used.
But i see this as an addition onto the libmpg123 work instead of a replacement of.
-aric
Chris Robinson wrote:
On Wednesday 19 August 2009 2:26:37 pm Matteo Bruni wrote:
What about using more popular libraries as libmad, lame or maybe gstreamer to decode mp3 files? I believe someone previously said that gstreamer is also available on Mac.
libmad is GPL, and IIRC lame uses libmpg123 or libmad for decoding. GStreamer seems rather hefty if you just need its mp3 decoder, IMO.
That is what I am worried about. I am willing to believe that direct show uses the acm drivers to decode the audio. I have not found anything to prove that yet but it is my gut feeling. -aric Henri Verbeet wrote:
2009/8/20 Roderick Colenbrander <thunderbird2k(a)gmail.com>:
If you are considering to write an additional backend, I would advise to add a fallback path to directshow. Wouldn't that potentially create a cyclic dependency?
2009/8/20 Aric Stewart <aric(a)codeweavers.com>:
That is what I am worried about. I am willing to believe that direct show uses the acm drivers to decode the audio. I have not found anything to prove that yet but it is my gut feeling.
Well, there's dlls/quartz/acmwrapper.c. That won't necessarily be used depending on which other filters are installed on a specific setup, but I don't think there's any guarantee that it won't.
On Wed, 19 Aug 2009 15:48:10 -0500 Alex Villacís Lasso <a_villacis(a)palosanto.com> wrote:
The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame.
According to rpmfind, libmpg123.so is included in the xmms-mp3 plugin packages in the rpmfusion free repository. http://rpmfind.net/linux/rpm2html/search.php?query=libmpg123.so&submit=Searc... -- Rosanne DiMesio <dimesio(a)earthlink.net>
Rosanne DiMesio escribió:
On Wed, 19 Aug 2009 15:48:10 -0500 Alex Villacís Lasso <a_villacis(a)palosanto.com> wrote:
The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame.
According to rpmfind, libmpg123.so is included in the xmms-mp3 plugin packages in the rpmfusion free repository. http://rpmfind.net/linux/rpm2html/search.php?query=libmpg123.so&submit=Searc...
Sorry, not usable. The patch needs not only the libmpg123.so file, but also the header files required for building a program that links against it. -- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
participants (7)
-
Alex Villacís Lasso -
Aric Stewart -
Chris Robinson -
Henri Verbeet -
Matteo Bruni -
Roderick Colenbrander -
Rosanne DiMesio