Re: [1/8] d3dx9: Add missing pixel formats.
2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>:
diff --git a/dlls/d3dx9_36/util.c b/dlls/d3dx9_36/util.c index 4dbf44c..ad8a6ea 100644 --- a/dlls/d3dx9_36/util.c +++ b/dlls/d3dx9_36/util.c @@ -62,6 +62,7 @@ static const PixelFormatDesc formats[] = {D3DFMT_G16R16, {0, 16, 16, 0}, { 0, 0, 16, 0}, 4, 1, 1, 4, FORMAT_ARGB, NULL, NULL }, {D3DFMT_A8, {8, 0, 0, 0}, { 0, 0, 0, 0}, 1, 1, 1, 1, FORMAT_ARGB, NULL, NULL }, {D3DFMT_A8L8, {8, 8, 0, 0}, { 8, 0, 0, 0}, 2, 1, 1, 2, FORMAT_ARGB, la_from_rgba, la_to_rgba}, + {D3DFMT_A4L4, {4, 4, 0, 0}, { 4, 0, 0, 0}, 1, 1, 1, 1, FORMAT_ARGB, la_from_rgba, la_to_rgba}, {D3DFMT_DXT1, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 8, FORMAT_ARGB, NULL, NULL }, {D3DFMT_DXT2, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 16, FORMAT_ARGB, NULL, NULL }, {D3DFMT_DXT3, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 16, FORMAT_ARGB, NULL, NULL },
I guess it would make sense to add all the new pixel formats to the table, assuming it doesn't break the tests or other stuff.
On Thu, May 10, 2012 at 4:25 PM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
I guess it would make sense to add all the new pixel formats to the table, assuming it doesn't break the tests or other stuff.
Luminance pixel formats could be added, but I'm not sure about BUMPDUDV pixel formats. For BUMPDUDV pixel formats probably some changes in the pixel conversion functions would be needed. I'll leave that for another patch.
On 10 May 2012 17:45, Józef Kucia <joseph.kucia(a)gmail.com> wrote:
Luminance pixel formats could be added, but I'm not sure about BUMPDUDV pixel formats. For BUMPDUDV pixel formats probably some changes in the pixel conversion functions would be needed. I'll leave that for another patch.
Yeah, the bumpmapping formats have signed components, and the existing code probably doesn't handle those very well, except perhaps for simple loads.
participants (3)
-
Henri Verbeet -
Józef Kucia -
Matteo Bruni