Re: [PATCH] GNU/kFreeBSD detection

[Alexandre Julliard]

Robert Millan <rmh(a)debian.org> writes:
> diff --git a/tools/winebuild/build.h b/tools/winebuild/build.h
> index 05adf31..cf389fb 100644
> --- a/tools/winebuild/build.h
> +++ b/tools/winebuild/build.h
> @@ -148,6 +148,7 @@ enum target_platform
>      PLATFORM_UNSPECIFIED,
>      PLATFORM_APPLE,
>      PLATFORM_FREEBSD,
> +    PLATFORM_GNUKFREEBSD,
>      PLATFORM_SOLARIS,
>      PLATFORM_WINDOWS
>  };

If it doesn't need a different behavior there's no need for a new
platform, just use PLATFORM_FREEBSD.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] GNU/kFreeBSD detection

[Robert Millan]

2011/8/22 Alexandre Julliard <julliard(a)winehq.org>:
> If it doesn't need a different behavior there's no need for a new
> platform, just use PLATFORM_FREEBSD.

It may need different behaviour in the future.  Anyhow, if you still
prefer to share the same macro here's the new patch.

Thanks

-- 
Robert Millan

[PATCH] GNU/kFreeBSD detection

[GOUJON Alexandre]

On 08/22/2011 07:11 PM, Robert Millan wrote:
> 2011/8/22 Alexandre Julliard<julliard(a)winehq.org>:
> > If it doesn't need a different behavior there's no need for a new
> > platform, just use PLATFORM_FREEBSD.
> > It may need different behaviour in the future.  Anyhow, if you still
> > prefer to share the same macro here's the new patch.
>
> Thanks

You have to send your patch to wine-patches with (try 2) in the subject 
and if needed a little changelog in the header so that AJ can see what 
changed, why...
There is one exception though : if you're unsure about a way you wrote a 
patch, you can send it here with RFC in the subject (meaning you're 
requesting comments).
In this case, you want feedback from other developers hence the wine -devel.