Re: mshtml/tests: Fix events test when pointer is on a corner.

[Jacek Caban]

Hi Nicolas,

Nicolas Le Cam wrote:
> Hi,
>
> Since commit 8272ecd3f2235b923f2ec67bb51d051bdfbf466f I'm having
> errors on events tests.
>
> I just found that it only fails if pointer is on any corner. As I'm
> always putting it on upper right corner when running winetest it was
> always failing for me.
>
> Minimizing the test window fixed it for me.
> Tested on Win2k SP4 and WinXP SP2 (both with IE6).

Minimizing window changes what we test and will break test interactive 
mode. We should change tests to accept cursor in left corner.


Thanks,
    Jacek

mshtml/tests: Fix events test when pointer is on a corner.

[Nicolas Le Cam]

2009/10/30 Jacek Caban <jacek(a)codeweavers.com>:
> Hi Nicolas,
>
> Nicolas Le Cam wrote:
> > Hi,
> >
> > Since commit 8272ecd3f2235b923f2ec67bb51d051bdfbf466f I'm having
> > errors on events tests.
> >
> > I just found that it only fails if pointer is on any corner. As I'm
> > always putting it on upper right corner when running winetest it was
> > always failing for me.
> >
> > Minimizing the test window fixed it for me.
> > Tested on Win2k SP4 and WinXP SP2 (both with IE6).
>
> Minimizing window changes what we test and will break test interactive mode.
> We should change tests to accept cursor in left corner.
>
> Thanks,
>   Jacek

Hi Jacek,

Thanks for feedback.
It should handle pointer in every corners IMHO, the left corner can
cause failures in winetest.

I'll try to find a better solution. Do you have any hints ?

-- 
Nicolas Le Cam

mshtml/tests: Fix events test when pointer is on a corner.

[Jacek Caban]

Hi Nicolas,

Nicolas Le Cam wrote:
> Hi Jacek,
>
> Thanks for feedback.
> It should handle pointer in every corners IMHO, the left corner can
> cause failures in winetest.
>
> I'll try to find a better solution. Do you have any hints ?

The test in line 472 is invalid. It looks like all we can do is check if 
get_x returned something. I'd suggest to set l to 0xdeadbeef before 
get_x call and test that the value has changed (ok(x != 0xdeadbeef, 
...)). That's all we can do. The same applies to get_client[XY] and 
get_offset[XY] tests.


Thanks,
    Jacek

mshtml/tests: Fix events test when pointer is on a corner.

[Nicolas Le Cam]

2009/10/30 Jacek Caban <jacek(a)codeweavers.com>:
> Hi Nicolas,
>
> Nicolas Le Cam wrote:
> > Hi Jacek,
> >
> > Thanks for feedback.
> > It should handle pointer in every corners IMHO, the left corner can
> > cause failures in winetest.
> >
> > I'll try to find a better solution. Do you have any hints ?
>
> The test in line 472 is invalid. It looks like all we can do is check if
> get_x returned something. I'd suggest to set l to 0xdeadbeef before get_x
> call and test that the value has changed (ok(x != 0xdeadbeef, ...)). That's
> all we can do. The same applies to get_client[XY] and get_offset[XY] tests.
>
> Thanks,git br
>   Jacek

Hi Jacek,

I did what you've suggested (patch's attached for reference) but I
don't think it's the right solution.
Test passes on Wine and Windows with such a patch, but we're now
ignoring the fact that values are completely different on Wine (only
-1 and 0) and Windows (cursor's position relative to something).

I'm trying to find a way to compare values against results from
GetCursorPos and friends. What do you think about that, could that be
a solution ?

Thanks,
Nicolas Le Cam

mshtml/tests: Fix events test when pointer is on a corner.

[Jacek Caban]

Hi Nicolas,

Nicolas Le Cam wrote:
> 2009/10/30 Jacek Caban <jacek(a)codeweavers.com>:
> > Hi Nicolas,
> >
> > Nicolas Le Cam wrote:
> > > Hi Jacek,
> > >
> > > Thanks for feedback.
> > > It should handle pointer in every corners IMHO, the left corner can
> > > cause failures in winetest.
> > >
> > > I'll try to find a better solution. Do you have any hints ?
> >
> > The test in line 472 is invalid. It looks like all we can do is check if
> > get_x returned something. I'd suggest to set l to 0xdeadbeef before get_x
> > call and test that the value has changed (ok(x != 0xdeadbeef, ...)). That's
> > all we can do. The same applies to get_client[XY] and get_offset[XY] tests.
> >
> > Thanks,git br
> >   Jacek
>
> Hi Jacek,
>
> I did what you've suggested (patch's attached for reference) but I
> don't think it's the right solution.
> Test passes on Wine and Windows with such a patch, but we're now
> ignoring the fact that values are completely different on Wine (only
> -1 and 0) and Windows (cursor's position relative to something).
>
> I'm trying to find a way to compare values against results from
> GetCursorPos and friends. What do you think about that, could that be
> a solution ?

I think your patch might go to Wine. If you can find a solution with 
more strict tests, that would be even better, but I'm afraid that 
GetCursorPos might be problematic. We won't know until we try.


Thanks,
    Jacek