[PATCH 1/2] dsound: Close speepev handle after releasing audio client.
It's used as audio client event handle, so it shouldn't be closed as long as audio client is alive. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dsound/dsound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Typo in subject is worth fixing. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> On Thu, Nov 22, 2018 at 08:23:53PM +0100, Jacek Caban wrote:
It's used as audio client event handle, so it shouldn't be closed as long as audio client is alive.
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dsound/dsound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c index 6a49d638e1..12f1e286b3 100644 --- a/dlls/dsound/dsound.c +++ b/dlls/dsound/dsound.c @@ -207,7 +207,6 @@ static ULONG DirectSoundDevice_Release(DirectSoundDevice * device) CloseHandle(device->thread); CloseHandle(device->thread_finished); } - CloseHandle(device->sleepev);
EnterCriticalSection(&DSOUND_renderers_lock); list_remove(&device->entry); @@ -234,6 +233,7 @@ static ULONG DirectSoundDevice_Release(DirectSoundDevice * device) IAudioStreamVolume_Release(device->volume); if(device->mmdevice) IMMDevice_Release(device->mmdevice); + CloseHandle(device->sleepev); HeapFree(GetProcessHeap(), 0, device->tmp_buffer); HeapFree(GetProcessHeap(), 0, device->cp_buffer); HeapFree(GetProcessHeap(), 0, device->buffer);
participants (2)
-
Andrew Eikum -
Jacek Caban