Re: [PATCH 3/4] xmllite: Set empty value for end element nodes.

[Nikolay Sivov]

On 21.03.2017 18:19, Jacek Caban wrote:
> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> ---
>  dlls/xmllite/reader.c | 1 +
>  1 file changed, 1 insertion(+)

Could you make this another node type case in GetValue? Like for
XmlNodeType_XmlDeclaration. The goal is to make sure empty static string
is returned unconditionally for certain node types, as opposed to
heap-allocated empty string.

[PATCH 3/4] xmllite: Set empty value for end element nodes.

[Jacek Caban]

On 21.03.2017 16:37, Nikolay Sivov wrote:
> On 21.03.2017 18:19, Jacek Caban wrote:
> > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> > ---
> >  dlls/xmllite/reader.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Could you make this another node type case in GetValue? Like for
> XmlNodeType_XmlDeclaration. The goal is to make sure empty static string
> is returned unconditionally for certain node types, as opposed to
> heap-allocated empty string.

Sure, I sent a new version. Thanks for review.

Jacek