Re: [PATCH 2/5] wined3d: Just enable ARB_shader_texture_lod if it's available.
On Tuesday 07 June 2011 11:06:25 Henri Verbeet wrote:
- if (gl_info->supported[ARB_SHADER_TEXTURE_LOD] && reg_maps->usestexldd) Why is reg_maps->usestexldd not true in pixel shaders?
On 7 June 2011 11:16, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
On Tuesday 07 June 2011 11:06:25 Henri Verbeet wrote:
- if (gl_info->supported[ARB_SHADER_TEXTURE_LOD] && reg_maps->usestexldd) Why is reg_maps->usestexldd not true in pixel shaders?
Well, it may be, but the instruction we care about here is texldl. I could of course add a usestexldl condition, but afaik there isn't any reason not to enable ARB_shader_texture_lod if it's available.
On Tuesday 07 June 2011 11:43:17 Henri Verbeet wrote:
On 7 June 2011 11:16, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
On Tuesday 07 June 2011 11:06:25 Henri Verbeet wrote:
- if (gl_info->supported[ARB_SHADER_TEXTURE_LOD] && reg_maps->usestexldd)
Why is reg_maps->usestexldd not true in pixel shaders?
Well, it may be, but the instruction we care about here is texldl. I could of course add a usestexldl condition, True, my bad. In that sense the usestexldd condition was broken anyway.
but afaik there isn't any reason not to enable ARB_shader_texture_lod if it's available. Yep, at least not unless there's some driver bug that triggers a slowdown like with enabling GL_NV_fragment_program* in ARB shaders. I guess my nightly tests will tell us tomorrow.
Fwiw, I don't expect ARB_shader_texture_lod to cost anything at least on Nvidia because their GLSL compiler enables NVfp anyway and it provides support for TXL in any case.
2011/6/7 Henri Verbeet <hverbeet(a)gmail.com>:
On 7 June 2011 11:16, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
On Tuesday 07 June 2011 11:06:25 Henri Verbeet wrote:
- if (gl_info->supported[ARB_SHADER_TEXTURE_LOD] && reg_maps->usestexldd) Why is reg_maps->usestexldd not true in pixel shaders?
Well, it may be, but the instruction we care about here is texldl. I could of course add a usestexldl condition, but afaik there isn't any reason not to enable ARB_shader_texture_lod if it's available.
Actually, there is already a usestexldl flag around. Unlikely that it would make any practical difference though...
On 7 June 2011 14:39, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
Well, it may be, but the instruction we care about here is texldl. I could of course add a usestexldl condition, but afaik there isn't any reason not to enable ARB_shader_texture_lod if it's available.
Actually, there is already a usestexldl flag around. Unlikely that it would make any practical difference though...
Yes. In case it wasn't entirely clear, what I meant was adding "reg_maps->usestexldl" to the existing "reg_maps->usestexldd" condition for enabling the extension.
2011/6/7 Henri Verbeet <hverbeet(a)gmail.com>:
On 7 June 2011 14:39, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
Well, it may be, but the instruction we care about here is texldl. I could of course add a usestexldl condition, but afaik there isn't any reason not to enable ARB_shader_texture_lod if it's available.
Actually, there is already a usestexldl flag around. Unlikely that it would make any practical difference though...
Yes. In case it wasn't entirely clear, what I meant was adding "reg_maps->usestexldl" to the existing "reg_maps->usestexldd" condition for enabling the extension.
Yep, I misunderstood...
participants (3)
-
Henri Verbeet -
Matteo Bruni -
Stefan Dösinger