World of Warcraft: fixed?

I applied the two patches from bugzilla (http://bugs.winehq.org/show_bug.cgi?id=2814#c8) which includes Raphael's opengl32 fbconf patch and another one from Tim Savannah  which looks like this:

--- wine2/dlls/x11drv/opengl.c	2005-03-24 20:51:16.000000000 -0500
+++ wine/dlls/x11drv/opengl.c	2005-03-24 20:50:14.000000000 -0500
@@ -268,9 +268,8 @@
   if ((iPixelFormat > MAX_PIXELFORMATS) ||
       (iPixelFormat > physDev->used_visuals + 1) ||
       (iPixelFormat <= 0)) {
-    ERR("Wrong pixel format !\n");
-    /* Should set error */
-    return 0;
+    ERR("Wrong pixel format, trying default. !\n");
+   iPixelFormat = physDev->used_visuals + 1;
   }
 
   if (iPixelFormat == physDev->used_visuals + 1) {


I note two things when using these patches:
1) WoW works.  Game loads and runs again.
2) The login/character select screen will occasionally be extremely choppy/slow.  Sometimes it happens, sometimes it doesn't, and there seems to be no direct cause from what I can tell since the traces are identical.  Once in the game it performs nicely from what I've seen, so it's really just a minor irritation.


Some, however, have reported that these two patches don't solve the problem.  As I am not one of those, I am unable to provide traces/details on this.  If I find any issues occurring regularly on my end, I'll send in the appropriate info so that you guys can take a look at it.

Thanks for the swift fixes!
Darckness

[Alex Woods]

On Thu, Mar 24, 2005 at 10:40:18PM -0500, cyrix12(a)cox.net wrote:
> I applied the two patches from bugzilla (http://bugs.winehq.org/show_bug.cgi?id=2814#c8) which includes Raphael's opengl32 fbconf patch and another one from Tim Savannah  which looks like this:
>
> --- wine2/dlls/x11drv/opengl.c	2005-03-24 20:51:16.000000000 -0500
> +++ wine/dlls/x11drv/opengl.c	2005-03-24 20:50:14.000000000 -0500
> @@ -268,9 +268,8 @@
>    if ((iPixelFormat > MAX_PIXELFORMATS) ||
>        (iPixelFormat > physDev->used_visuals + 1) ||
>        (iPixelFormat <= 0)) {
> -    ERR("Wrong pixel format !\n");
> -    /* Should set error */
> -    return 0;
> +    ERR("Wrong pixel format, trying default. !\n");
> +   iPixelFormat = physDev->used_visuals + 1;
>    }
>
> if (iPixelFormat == physDev->used_visuals + 1) {

The WoW patch has hit the European servers now, so I've had a chance to
try things out.  These patches work great for me - everything is running
as it should.
> I note two things when using these patches:
> 1) WoW works.  Game loads and runs again.
> 2) The login/character select screen will occasionally be extremely
> choppy/slow.  Sometimes it happens, sometimes it doesn't, and there
> seems to be no direct cause from what I can tell since the traces are
> identical.  Once in the game it performs nicely from what I've seen,
> so it's really just a minor irritation.

I've not noticed any choppiness in the character selection screen.  I've
noticed some choppiness turning in some places, but it doesn't feel like
a wine problem.
> Thanks for the swift fixes!

I'll second that :)

-- 
Alex

On Sat, 26 Mar 2005 11:35:58 +0000
Alex Woods <wine-devel(a)giblets.org> wrote:
> On Thu, Mar 24, 2005 at 10:40:18PM -0500, cyrix12(a)cox.net wrote:
> > I applied the two patches from bugzilla (http://bugs.winehq.org/show_bug.cgi?id=2814#c8) which includes Raphael's opengl32 fbconf patch and another one from Tim Savannah  which looks like this:
> >
> > --- wine2/dlls/x11drv/opengl.c	2005-03-24 20:51:16.000000000 -0500
> > +++ wine/dlls/x11drv/opengl.c	2005-03-24 20:50:14.000000000 -0500
> > @@ -268,9 +268,8 @@
> >    if ((iPixelFormat > MAX_PIXELFORMATS) ||
> >        (iPixelFormat > physDev->used_visuals + 1) ||
> >        (iPixelFormat <= 0)) {
> > -    ERR("Wrong pixel format !\n");
> > -    /* Should set error */
> > -    return 0;
> > +    ERR("Wrong pixel format, trying default. !\n");
> > +   iPixelFormat = physDev->used_visuals + 1;
> >    }
> >
> > if (iPixelFormat == physDev->used_visuals + 1) {
>
> The WoW patch has hit the European servers now, so I've had a chance to
> try things out.  These patches work great for me - everything is running
> as it should.
> > I note two things when using these patches:
> > 1) WoW works.  Game loads and runs again.
> > 2) The login/character select screen will occasionally be extremely
> > choppy/slow.  Sometimes it happens, sometimes it doesn't, and there
> > seems to be no direct cause from what I can tell since the traces are
> > identical.  Once in the game it performs nicely from what I've seen,
> > so it's really just a minor irritation.
>
> I've not noticed any choppiness in the character selection screen.  I've
> noticed some choppiness turning in some places, but it doesn't feel like
> a wine problem.
> > Thanks for the swift fixes!
>
> I'll second that :)
>
> -- 
> Alex

I've discovered that the choppiness I was experiencing can be fixed simply by giving focus to another window and then switching back to the game.  It's an even smaller issue than I thought!

Darckness