Re: [2/2] programs/msiexec: MSI service should report SERVICE_STOPPED when appropriate.

[André Hentschel]

Am 11.12.2013 09:16, schrieb Dmitry Timoshkov:
> ---
>  programs/msiexec/service.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/programs/msiexec/service.c b/programs/msiexec/service.c
> index 4b72fe0..fdd29bd 100644
> --- a/programs/msiexec/service.c
> +++ b/programs/msiexec/service.c
> @@ -81,6 +81,8 @@ static BOOL UpdateSCMStatus(DWORD dwCurrentState, DWORD dwWin32ExitCode,
>
> static void WINAPI ServiceCtrlHandler(DWORD code)
>  {
> +    DWORD state = SERVICE_RUNNING;
> +
>      WINE_TRACE("%d\n", code);
>
> switch (code)
> @@ -89,13 +91,14 @@ static void WINAPI ServiceCtrlHandler(DWORD code)
>          case SERVICE_CONTROL_STOP:
>              UpdateSCMStatus(SERVICE_STOP_PENDING, NO_ERROR, 0);
>              KillService();
> +            state = SERVICE_STOPPED;
>              return;

Hi,
setting the variable here seems to have no effect
i just have seen that from the patch without a look at the code, so i still might be wrong...