Re: fix for bug 9665

[James Hawkins]

On 9/17/07, Martin <martin.marsan(a)gmail.com> wrote:
> 2007-09-17  Martin Sand <deadlock(a)start.no>
>
> * dlls/ddraw/direct3d.c:
>         ddraw: fixes a bug which prevents Kings Quest 8 from starting(bug 9665)

A good changelog entry details what you changed, not what apps are
fixed by a change.

-- 
James Hawkins

fix for bug 9665

[Robert Shearman]

James Hawkins wrote:
> On 9/17/07, Martin <martin.marsan(a)gmail.com> wrote:
> > 2007-09-17  Martin Sand <deadlock(a)start.no>
> >
> > * dlls/ddraw/direct3d.c:
> >         ddraw: fixes a bug which prevents Kings Quest 8 from starting(bug 9665)
>
> A good changelog entry details what you changed, not what apps are
> fixed by a change.

Actually, a good changelog entry also describes why something was 
changed, if not obvious from the patch such as fixing a todo_wine in the 
tests.

Although as James says, you'll need a better reason than just fixing a 
program though, as that hints at programming by trial-and-error rather 
than by reason.

-- 
Rob Shearman