Re: [1/3] msxml3: Use the associated schema for domelem_get_dataType()

[Jacek Caban]

Hi Adam,

On 11/16/10 23:00, Adam Martinson wrote:
> ---
>  dlls/msxml3/element.c       |   95 +++++++++++++-
>  dlls/msxml3/msxml_private.h |    1 +
>  dlls/msxml3/node.c          |  248 ++++++++++++++++++++++++++++++++++--
>  dlls/msxml3/tests/domdoc.c  |  301
> +++++++++++++++++++++++++++++++++++--------
>  4 files changed, 574 insertions(+), 71 deletions(-)

+    if(This->node->type == XML_ELEMENT_NODE)
+    {
+        XDR_DT dt = element_get_dt(This->node);
+        content = xmlNodeGetContent(This->node);
+        hres = VARIANT_from_DT(dt, content, typedValue);
+        xmlFree(content);
+    }
+    else if (This->node->type == XML_TEXT_NODE ||
+             This->node->type == XML_ENTITY_REF_NODE)
+    {


Please use inheritance for this. We're in process of getting rid of
xmlnode_* functions. Such differences in implementation should be
handled in node type-specific objects.

Jacek