Re: [PATCH] ntsync: Set the permissions to be 0666

[Elizabeth Figura]

On Friday, 14 February 2025 06:28:00 CST Mike Lothian wrote:
> This allows ntsync to be usuable by non-root processes out of the box
>
> Signed-off-by: Mike Lothian <mike(a)fireburn.co.uk>
> ---
>  drivers/misc/ntsync.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
> index 055395cde42b..586b86243e1d 100644
> --- a/drivers/misc/ntsync.c
> +++ b/drivers/misc/ntsync.c
> @@ -1208,6 +1208,7 @@ static struct miscdevice ntsync_misc = {
>   .minor		= MISC_DYNAMIC_MINOR,
>   .name		= NTSYNC_NAME,
>   .fops		= &ntsync_fops,
> +	.mode		= 0666, // Setting file permissions to 0666
>  };
>
> module_misc_device(ntsync_misc);

Reviewed-by: Elizabeth Figura <zfigura(a)codeweavers.com>

--

The comment seems rather redundant, but otherwise this is correct and prudent.