Fw: [PATCH] CMD.exe: Remove code duplication for _splitpath

[Ann & Jason Edmeades]

"Alexandre Julliard" <julliard(a)winehq.org> wrote in message
news:<87d51qw39a.fsf(a)wine.dyndns.org>...
> Jason Edmeades <us(a)edmeades.me.uk> writes:
> > Note: This makes cmd.exe pull in msvcrt, but so does native
>
> Native doesn't have a choice, but we do. Unless there are good reasons 
> to import msvcrt it's better to stick to standard libc.

Well, I am trying to convert cmd.exe to unicode, and was hoping to use the
wide crt functions to replace e.g. strstr, strdup etc. This way it's a
relatively simple transition from char to WCHAR without having to rewrite
other functions. LstrcatW and lstrcpyW help, but there's other functions
with no non-CRT equivalents.

Does this change your mind? :-)

Jason

[Alexandre Julliard]

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes:
> Well, I am trying to convert cmd.exe to unicode, and was hoping to use the
> wide crt functions to replace e.g. strstr, strdup etc. This way it's a
> relatively simple transition from char to WCHAR without having to rewrite
> other functions. LstrcatW and lstrcpyW help, but there's other functions
> with no non-CRT equivalents.
>
> Does this change your mind? :-)

It depends on how many there are, but in general I think using the
Unicode functions from libwine is less confusing than the wcs* ones
since we are not using a real wchar_t.

-- 
Alexandre Julliard
julliard(a)winehq.org