Re: [PATCH] advapi32/tests: Test RegDeleteKey with empty string parameter

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Content-wise this looks ok to me. But please mark a resubmission of a patch in the subject line and preferably say something like "This supersedes patch XXXXXX" in the patch desciption and add a small explanation what changed. (No need to resend this one. Just keep it in mind for the future.)

Stefan

Am 2014-11-06 19:18, schrieb Jonathan Vollebregt:
> ---
>  dlls/advapi32/tests/registry.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c
> index 23eafab..55a74f6 100644
> --- a/dlls/advapi32/tests/registry.c
> +++ b/dlls/advapi32/tests/registry.c
> @@ -1372,6 +1372,7 @@ static void test_reg_close_key(void)
>  static void test_reg_delete_key(void)
>  {
>      DWORD ret;
> +    HKEY key;
>
> ret = RegDeleteKeyA(hkey_main, NULL);
>
> @@ -1390,6 +1391,15 @@ static void test_reg_delete_key(void)
>             ret == ERROR_ACCESS_DENIED ||
>             ret == ERROR_BADKEY, /* Win95 */
>             "ret=%d\n", ret);
> +
> +    ret = RegCreateKeyA(hkey_main, "deleteme", &key);
> +    ok(ret == ERROR_SUCCESS, "Could not create key, got %d\n", ret);
> +    ret = RegDeleteKeyA(key, "");
> +    ok(ret == ERROR_SUCCESS, "RegDeleteKeyA failed, got %d\n", ret);
> +    RegCloseKey(key);
> +    ret = RegOpenKeyA(hkey_main, "deleteme", &key);
> +    ok(ret == ERROR_FILE_NOT_FOUND, "Key was not deleted, got %d\n", ret);
> +    RegCloseKey(key);
>  }
>
> static void test_reg_save_key(void)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUW8qZAAoJEN0/YqbEcdMwE+AP/3ZkydOTA8XW2U0Dx5NlNTeZ
d6tNj1fcVyY7XZs/+/LSBUjUsS1STy+UN6PInVp2rvYVJ057PP28768pghzzDRiP
ZC98QHls3nx8qXtIhjUTUDWDZFFFJlScf81qkm1QKhc/zQ4+KWX1ndUOgNJsc6F5
T7x7OaQP5uniOodw1D0OZmqpbAFMxa9jMX3M4StNzGvrO+WPj7anriuA56Fb/tWW
oQxItSe0r7uSX6+1Xj0nWYK+Wv1q73GicVP98t85IOA2FgyBWEyTlaw3A/LeyENh
LxW/b5qN2VfTMfs5I5kBKbC7QhOzNHZo0cjKBgkN2xKi2K6+1v+F0UI3+Dajvjg6
Sez4NphgMMMRSaZlqo8G9SX8gjgIVhyfo0RyqU85YoFvHXL97nw3C0Xhz5Iqbf7Y
TZcpGxLVOYcl/jqITPVQYrwpyds5eT/vxvBfE32/eMwEi8lH5qGTYQkykditOX+a
5/nVXUAasyRmBq/nb4oDFdTXFX2saxcM9QpeptIc5sKwWYHe9bQ+w44fIAC9hCSP
nZyDCUTymjuofS1EqD8ZzOebUf+0/Dfujm6odn7pUHg6ZdKqS9aX4BXfSJfJTg6M
Quh3F+bX8lTe60wXyQQ9UbVpYEIOkCBJMQoPlM+qHLVRgR1oJK6fpXLvFYp8o2sV
b68XSbGXriHFUMhKcPkz
=tXkF
-----END PGP SIGNATURE-----