[PATCH 6/7] comctl32/taskdialog: Add support for TDF_NO_SET_FOREGROUND.

[Zhiyi Zhang]

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>
---
 dlls/comctl32/taskdialog.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c
index a0d38051b2..7066b793c8 100644
--- a/dlls/comctl32/taskdialog.c
+++ b/dlls/comctl32/taskdialog.c
@@ -542,6 +542,7 @@ static DLGTEMPLATE *create_taskdialog_template(const TASKDIALOGCONFIG *taskconfi
 
     template->style = DS_MODALFRAME | DS_SETFONT | WS_CAPTION | WS_VISIBLE | WS_SYSMENU;
     if (taskconfig->dwFlags & TDF_CAN_BE_MINIMIZED) template->style |= WS_MINIMIZEBOX;
+    if (!(taskconfig->dwFlags & TDF_NO_SET_FOREGROUND)) template->style |= DS_SETFOREGROUND;
     template->cdit = desc.control_count;
 
     ptr = (char *)(template + 1);
-- 
2.17.0

[Nikolay Sivov]

On 05/16/2018 07:15 PM, Zhiyi Zhang wrote:
> Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>
> ---
>   dlls/comctl32/taskdialog.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c
> index a0d38051b2..7066b793c8 100644
> --- a/dlls/comctl32/taskdialog.c
> +++ b/dlls/comctl32/taskdialog.c
> @@ -542,6 +542,7 @@ static DLGTEMPLATE *create_taskdialog_template(const TASKDIALOGCONFIG *taskconfi
>
> template->style = DS_MODALFRAME | DS_SETFONT | WS_CAPTION | WS_VISIBLE | WS_SYSMENU;
>       if (taskconfig->dwFlags & TDF_CAN_BE_MINIMIZED) template->style |= WS_MINIMIZEBOX;
> +    if (!(taskconfig->dwFlags & TDF_NO_SET_FOREGROUND)) template->style |= DS_SETFOREGROUND;
>       template->cdit = desc.control_count;
>
> ptr = (char *)(template + 1);

Looks like this style is not considered in dialog code.

[Zhiyi Zhang]

No. This style is not handled in the dialog code. So testing it shows no difference.
But adding it here wouldn't hurt anyway should we consider it someday.

On Thu 5 17 16:35, Nikolay Sivov wrote:
> On 05/16/2018 07:15 PM, Zhiyi Zhang wrote:
> > Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>
> > ---
> >   dlls/comctl32/taskdialog.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c
> > index a0d38051b2..7066b793c8 100644
> > --- a/dlls/comctl32/taskdialog.c
> > +++ b/dlls/comctl32/taskdialog.c
> > @@ -542,6 +542,7 @@ static DLGTEMPLATE *create_taskdialog_template(const TASKDIALOGCONFIG *taskconfi
> >         template->style = DS_MODALFRAME | DS_SETFONT | WS_CAPTION | WS_VISIBLE | WS_SYSMENU;
> >       if (taskconfig->dwFlags & TDF_CAN_BE_MINIMIZED) template->style |= WS_MINIMIZEBOX;
> > +    if (!(taskconfig->dwFlags & TDF_NO_SET_FOREGROUND)) template->style |= DS_SETFOREGROUND;
> >       template->cdit = desc.control_count;
> >         ptr = (char *)(template + 1);
>
> Looks like this style is not considered in dialog code.