Re: [PATCH 3/3] d3dx9: Use all 32 bits as mask.

[Matteo Bruni]

2013/1/10 Rico Schüller <kgbricola(a)web.de>:
> ---
>  dlls/d3dx9_36/texture.c | 6 +++---
>  1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-
>
> -        DWORD i, v;
> +        DWORD i, v, mask32 = format->bits[c] == 32 ? -1 : ((1 << format->bits[c]) - 1);

Usually we prefer to use ~0U instead of -1 with unsigned variables.

Nice cleanups and fixes for larger pixel formats. Is this for Alan Wake?

[PATCH 3/3] d3dx9: Use all 32 bits as mask.

[Rico Schüller]

On 10.01.2013 17:13, Matteo Bruni wrote:
> 2013/1/10 Rico Schüller <kgbricola(a)web.de>:
> > ---
> >   dlls/d3dx9_36/texture.c | 6 +++---
> >   1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-
> >
> > -        DWORD i, v;
> > +        DWORD i, v, mask32 = format->bits[c] == 32 ? -1 : ((1 << format->bits[c]) - 1);
>
> Usually we prefer to use ~0U instead of -1 with unsigned variables.
>
> Nice cleanups and fixes for larger pixel formats. Is this for Alan Wake?

Yes, but alan wake needs only D3DFMT_A16B16G16R16F. I stumbled over the 
tests and I'd like to add later D3DFMT_A32B32G32R32F, thus the 
correction for the mask is needed.

Thanks for the hint, i'll send an improved version.

Cheers
Rico