Re: revert of a6c07ffba4b2b37d01affb4c39f032bb5f8d34bf

[Francois Gouget]

A little bit of explanation would be nice...



-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
                           La terre est une bêta...

revert of a6c07ffba4b2b37d01affb4c39f032bb5f8d34bf

[Steven Edwards]

On Thu, Feb 19, 2009 at 5:43 AM, Francois Gouget <fgouget(a)free.fr> wrote:
> A little bit of explanation would be nice...

I thought the Changelog in the patch would explain enough. MSG_WAITALL
is not defined on Cygwin when building wininet or winhttp without it.
Since I can't rebuild all of Wine and I've not checked on MSVC to see
if its just a w32api thing, maybe this one should be held off.




-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

revert of a6c07ffba4b2b37d01affb4c39f032bb5f8d34bf

[Francois Gouget]

On Thu, 19 Feb 2009, Steven Edwards wrote:
> On Thu, Feb 19, 2009 at 5:43 AM, Francois Gouget <fgouget(a)free.fr> wrote:
> > A little bit of explanation would be nice...
>
> I thought the Changelog in the patch would explain enough. MSG_WAITALL
> is not defined on Cygwin when building wininet or winhttp without it.
> Since I can't rebuild all of Wine and I've not checked on MSVC to see
> if its just a w32api thing, maybe this one should be held off.

Since it was a revert I did not expect anything in the patch. In fact 
it's not a revert at all since the diff is completely different from the 
original patch.

Well, since Cygwin is a Unix platform after a fashion (iirc), I don't 
think you need to check with MSVC (with MinGW it would be different). So 
I think your patch is ok.

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
                            1 + e ^ ( i * pi ) = 0

revert of a6c07ffba4b2b37d01affb4c39f032bb5f8d34bf

[Francois Gouget]

On Fri, 20 Feb 2009, Francois Gouget wrote:
[...]
> Well, since Cygwin is a Unix platform after a fashion (iirc), I don't 
> think you need to check with MSVC (with MinGW it would be different). So 
> I think your patch is ok.

You should add a comment in the port.h file saying that this define is 
needed for Cygwin though (so the next one who stumbles on this 
suspicious define knows why it was put there).

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
            "Lotto: A tax on people who are bad at math." -- unknown
          "Windows: Microsoft's tax on computer illiterates." -- WE7U