[1/7] [wined3d] add ps_np2fixup_t ptr to shader_arb_priv (review)

[Tobias Jakobi]

For review:

This patchset implements np2 texcoord fixup in ARB mode. Constants used to store texture dimensions are already packed, using the same data structures like the GLSL packing code.

The code is finished and works quite well. It has been tested with Max Payne 2, HL2 and FEAR. All games now work with post-processing effects and anything else that needs NP2 textures on the nvidia FX series.

Greets,
Tobias

-- 
Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

[James McKenzie]

Tobias Jakobi wrote:
> For review:
>
> This patchset implements np2 texcoord fixup in ARB mode. Constants used to store texture dimensions are already packed, using the same data structures like the GLSL packing code.
>
> The code is finished and works quite well. It has been tested with Max Payne 2, HL2 and FEAR. All games now work with post-processing effects and anything else that needs NP2 textures on the nvidia FX series.
>
> Greets,
> Tobias
>
> ------------------------------------------------------------------------

Tobias:

Do you plan on rewriting this to work in the backend?

James McKenzie

[Tobias Jakobi]

James McKenzie wrote:
> Tobias Jakobi wrote:
> > For review:
> >
> > This patchset implements np2 texcoord fixup in ARB mode. Constants used to store texture dimensions are already packed, using the same data structures like the GLSL packing code.
> >
> > The code is finished and works quite well. It has been tested with Max Payne 2, HL2 and FEAR. All games now work with post-processing effects and anything else that needs NP2 textures on the nvidia FX series.
> >
> > Greets,
> > Tobias
> >
> > ------------------------------------------------------------------------
>
> Tobias:
>
> Do you plan on rewriting this to work in the backend?
>
> James McKenzie

Hi James,

my plan is currently the following:
(1) Wait until stefand has implemented backend_private_data
(2) Adapt the GLSL constant packing patchset to this (trivial)
(3) Adapt the ARB code (also trivial) and submit it - apart from the
backend_private_data changes there isn't anything else needed
(4) Write NP2 fixup code for the vertexshader-only case and implement it
in GLSL (ARB is too difficult)
(5) Resolve bug #14762 to fixed

Greets,
Tobias