Re: macdrv: implement getting and setting the screen saver state, version 5

[Ken Thomases]

On Jan 22, 2013, at 12:22 PM, C.W. Betts wrote:
> This version should fix the problems you mentioned

Sorry about this – I should have thought about this last time – but I think you shouldn't fall through in the SPI_SETSCREENSAVEACTIVE case.  It's asking for trouble in the future, if anybody adds another case to the switch statement.

I think it would be better to just explicitly return FALSE and put in a comment explaining why (like you suggested for the X11 driver).

Thanks for your persistence!

-Ken