Re: Change BITS_IBackgroundCopyJob_SetPriority to a stub so the EvE-Online patcher works.

[Ricardo Filipe]

2009/5/20 Tim Wright <timw(a)splhi.com>
> The EvE-online updater blows up because it's trying to set the download
> priority in BITS (qmgr) and that isn't implemented. Simply stubbing it to
> return S_OK is sufficient to allow it to work.
>
> Third attempt at sending. For some reason, it isn't being posted from
> git-send-email even though the Cc: arrives just fine at another account.
> Patch against git repository. This is bug 18528/12312.
>
> ---
>  dlls/qmgr/job.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c
> index 3baa893..09693a3 100644
> --- a/dlls/qmgr/job.c
> +++ b/dlls/qmgr/job.c
> @@ -334,8 +334,8 @@ static HRESULT WINAPI
> BITS_IBackgroundCopyJob_SetPriority(
>     IBackgroundCopyJob2 *iface,
>     BG_JOB_PRIORITY Val)
>  {
> -    FIXME("Not implemented\n");
> -    return E_NOTIMPL;
> +    FIXME("(%p,0x%08x) stub\n", iface, Val);
> +    return S_OK;
>  }
>
> static HRESULT WINAPI BITS_IBackgroundCopyJob_GetPriority(
> --
> 1.6.0.4
>
> your previous patch was already commited. check git page the next day when
> you send patches.
> http://source.winehq.org/git/wine.git/?a=commit;h=cb26244adb4e15ab60e4d02b5b...

;)

Change BITS_IBackgroundCopyJob_SetPriority to a stub so the EvE-Online patcher works.

[Tim Wright]

Sorry to everyone for spamming the patch. I was checking "
http://www.winehq.org/pipermail/wine-patches/2009-May/date.html" and wasn't
seeing it show up so I assumed I had some kind of mail-sending problem at my
end. It won't happen again!

Regards,

Tim


On Wed, May 20, 2009 at 11:03 AM, Ricardo Filipe
<ricardojdfilipe(a)gmail.com>wrote:
> 2009/5/20 Tim Wright <timw(a)splhi.com>
> > The EvE-online updater blows up because it's trying to set the download
> > priority in BITS (qmgr) and that isn't implemented. Simply stubbing it to
> > return S_OK is sufficient to allow it to work.
> >
> > Third attempt at sending. For some reason, it isn't being posted from
> > git-send-email even though the Cc: arrives just fine at another account.
> > Patch against git repository. This is bug 18528/12312.
> >
> > ---
> >  dlls/qmgr/job.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c
> > index 3baa893..09693a3 100644
> > --- a/dlls/qmgr/job.c
> > +++ b/dlls/qmgr/job.c
> > @@ -334,8 +334,8 @@ static HRESULT WINAPI
> > BITS_IBackgroundCopyJob_SetPriority(
> >     IBackgroundCopyJob2 *iface,
> >     BG_JOB_PRIORITY Val)
> >  {
> > -    FIXME("Not implemented\n");
> > -    return E_NOTIMPL;
> > +    FIXME("(%p,0x%08x) stub\n", iface, Val);
> > +    return S_OK;
> >  }
> >
> > static HRESULT WINAPI BITS_IBackgroundCopyJob_GetPriority(
> > --
> > 1.6.0.4
> >
> > your previous patch was already commited. check git page the next day when
> > you send patches.
>
> http://source.winehq.org/git/wine.git/?a=commit;h=cb26244adb4e15ab60e4d02b5b...
>
> ;)