Re: [v12 4/4] d3dx9: Implement setting named shader constants in effect.

[Matteo Bruni]

2016-04-14 12:30 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>:

A bunch of nitpicks:
> +    for (i = 0; i < parameters_count; i++)

++i
> +            TRACE("sampler %s, register index %u, state count %u.\n", params[i]->name,
> +                    cdesc[i].RegisterIndex, sampler->state_count);

You probably want to use debugstr_a().
> +static HRESULT set_shader_constants_device(struct IDirect3DDevice9 *device, struct d3dx_regstore *rs,
> +        D3DXPARAMETER_TYPE type, enum pres_reg_tables table)
> +{
> +    unsigned int start, n;

Better to call it "count" for consistency IMO.
> +        if (!n)
> +            continue;

That works but a break seems clearer.