[PATCH] conhost: Add the case where the divisor is 0.
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=79101 Your paranoid android. === debiant (build log) === Task: WineTest did not produce the wow32 report
On 22.09.2020 07:32, Pengpeng Dong wrote:
region->Right = min( x + width, screen_buffer->width ) - 1; - region->Bottom = min( y + entry_cnt / width, screen_buffer->height ) - 1; + if (width) + region->Bottom = min( y + entry_cnt / width, screen_buffer->height ) - 1; + else + region->Bottom = y + (x + i - 1) / screen_buffer->width
Note that in this case region->Right will have a meaningless value. The whole case is not really meant to be supported: SMALL_RECT result is meant to be used when we write to a region, which can't have 0 width. This is already validated on kernelbase side. On conhost side, we could probably return STATUS_INVALID_PARAMETER in this case. Thanks, Jacek
participants (3)
-
Jacek Caban -
Marvin -
Pengpeng Dong