Re: wine/ tools/wine.inf include/config.h.in dlls/ ...

[Vincent Béron]

Le jeu 04/11/2004 à 16:15, Alexandre Julliard a écrit :
> Log message:
>   Michael Jung <mjung(a)iss.tu-darmstadt.de>
>   Implemented a substantial part of rsaenh.dll.
>
> Patch: http://cvs.winehq.org/patch.py?id=14412

The committed patch doesn't compile on RH8. OpenSSL doesn't use the same
name for some datatypes/functions as the version used by Michael
(actually the prototype is different as well).

OpenSSL 0.9.7a (as found on FC1) will use OPENSSL_ENABLE_OLD_DES_SUPPORT
by default which will #define the old names to the new ones for the DES
functions.

RSAPrivateKey_dup is only defined in x509.h in OpenSSL 0.9.6b, not in
rsa.h. But pulling in x509.h also includes md4.h, md5.h and sha.h (via
evp.h), which redefine MD4_CTX (and MD5 and SHA _CTX also) with an
incompatible definition if the NO_MD4, etc. are not defined.

Changelog:
Allow rsaenh compilation with older (0.9.6b) OpenSSL version.
Remove a cast from const to not-const.

Vincent

wine/ tools/wine.inf include/config.h.in dlls/ ...

[Michael Jung]

On Friday 05 November 2004 21:50, Vincent Béron wrote:
> Le jeu 04/11/2004 à 16:15, Alexandre Julliard a écrit :
> > Log message:
> >  Michael Jung <mjung(a)iss.tu-darmstadt.de>
> >  Implemented a substantial part of rsaenh.dll.
> >
> > Patch: http://cvs.winehq.org/patch.py?id=14412
>
> The committed patch doesn't compile on RH8. OpenSSL doesn't use the same
> name for some datatypes/functions as the version used by Michael
> (actually the prototype is different as well).
>
> ...

Hi Vincent,

sorry for causing you problems.
> + pbKeyStream_no_const = StrDupA(pbKeyStream);
> + encrypt_block_impl(pPubKey->aiAlgid, &pPubKey->context, 
> pbKeyStream_no_const, pbDecrypted,

This doesn't seem to be correct. You can't apply a string duplication function 
to clone a pbKeyStream since it is not a zero terminated string. I also don't 
consider it beneficial to have a dependecy on shlwapi for this API. 
Furthermore, I think this duplication should be done inside 
encrypt_block_impl (if at all). 

I'm currently working on integrating source code from LibTomCrypt into rsaenh, 
which will help us to get rid of the OpenSSL dependency. I'm hoping to get it 
ready for the weekend.

Greetings,
Michael