Re: [PATCH] wined3d: Turn magic values into static constants.

[Henri Verbeet]

The patch isn't wrong, but I don't think the subject is an appropriate
description of what it does.

[PATCH] wined3d: Turn magic values into static constants.

[Alex Henrie]

2015-11-13 5:55 GMT-07:00 Henri Verbeet <hverbeet(a)gmail.com>:
> The patch isn't wrong, but I don't think the subject is an appropriate
> description of what it does.

What would you like the subject to say?

-Alex

[PATCH] wined3d: Turn magic values into static constants.

[Zhenbo Li]

2015-11-14 12:52 GMT+08:00 Alex Henrie <alexhenrie24(a)gmail.com>:
> What would you like the subject to say?

How about "Turn constants values into static constants.", as the magic
values are still magic values?


-- 
Have a nice day!
Zhenbo Li