[PATCH] user32/tests: Remove the Cygwin/XFree86 checks.

[Francois Gouget]

They are very old and likely no longer relevant.

Signed-off-by: Francois Gouget <fgouget(a)free.fr>
---
 dlls/user32/tests/sysparams.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/dlls/user32/tests/sysparams.c b/dlls/user32/tests/sysparams.c
index d49d69989f6..8fab62c951e 100644
--- a/dlls/user32/tests/sysparams.c
+++ b/dlls/user32/tests/sysparams.c
@@ -821,13 +821,6 @@ static void test_SPI_SETBORDER( void )                 /*      6 */
             "Control Panel\\Desktop\\WindowMetrics","CaptionWidth", dpi);
     ncmsave.iCaptionWidth = CaptionWidth;
 
-    /* These tests hang when XFree86 4.0 for Windows is running (tested on
-     *  WinNT, SP2, Cygwin/XFree 4.1.0. Skip the test when XFree86 is
-     * running.
-     */
-    if (FindWindowA( NULL, "Cygwin/XFree86" ))
-        return;
-
     trace("testing SPI_{GET,SET}BORDER\n");
 
     SetLastError(0xdeadbeef);
@@ -1127,13 +1120,6 @@ static void test_SPI_SETICONTITLEWRAP( void )          /*     26 */
     unsigned int i;
     ICONMETRICSA im;
 
-    /* These tests hang when XFree86 4.0 for Windows is running (tested on
-     * WinNT, SP2, Cygwin/XFree 4.1.0. Skip the test when XFree86 is
-     * running.
-     */
-    if (FindWindowA( NULL, "Cygwin/XFree86" ))
-        return;
-
     trace("testing SPI_{GET,SET}ICONTITLEWRAP\n");
     SetLastError(0xdeadbeef);
     rc=SystemParametersInfoA( SPI_GETICONTITLEWRAP, 0, &old_b, 0 );
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=90080

Your paranoid android.


=== w8 (32 bit report) ===

user32:
sysparams.c:2494: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out
sysparams.c:2505: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

=== w8adm (32 bit report) ===

user32:
sysparams.c:2494: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out
sysparams.c:2505: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

=== w864 (32 bit report) ===

user32:
sysparams.c:2494: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out
sysparams.c:2505: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

=== w1064v1809 (32 bit report) ===

user32:
sysparams.c:2494: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out
sysparams.c:2505: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

=== w1064 (32 bit report) ===

user32:
sysparams.c:2494: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out
sysparams.c:2505: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

=== w1064_tsign (32 bit report) ===

user32:
sysparams.c:2494: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out
sysparams.c:2505: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

=== w10pro64 (32 bit report) ===

user32:
sysparams.c:2494: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out
sysparams.c:2505: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

=== w10pro64_he (64 bit report) ===

user32:
sysparams.c:245: Test failed: too many changes counter=1 last change=8229