Re: msvcrt:locale Remove todo_wine and add broken when necessary

[Octavian Voicu]

On Tue, Aug 24, 2010 at 12:44 PM, Alexandre Goujon <ale.goujon(a)gmail.com> wrote:
> -        todo_wine ok(!strcmp(ret, "Chinese (Simplified)_People's Republic of China.936")
> +        ok(!strcmp(ret, "Chinese (Simplified)_People's Republic of China.936")
> +        || broken(!strcmp(ret, "Chinese_People's Republic of China.936"))

broken() only works for tests that fail on some Windows versions; it
has no effect on Wine, see [1].

Proper way to fix this bug is to make setlocale replicate Windows behavior.

Octavian


[1] http://source.winehq.org/git/wine.git/?a=blob;f=include/wine/test.h;h=1a9802...

msvcrt:locale Remove todo_wine and add broken when necessary

[GOUJON Alexandre]

On 08/24/2010 02:51 PM, Octavian Voicu wrote:
> broken() only works for tests that fail on some Windows versions; it
> has no effect on Wine, see [1].

My mistake.
> Proper way to fix this bug is to make setlocale replicate Windows behavior.

I'll investigate further to fix it this way.

Thanks