Re: resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars

[Alexandre Julliard]

"Jens Collin" <jens.collin(a)lakhei.com> writes:
> +			{
> +				TRACE("The env. var can't be found or is bigger than MAX_PATH => useless.");
> +				res += sprintfW(res, L"%s%%", tmpBuffer);

You cannot use Unicode strings constants in Wine, they don't have the
right size.

-- 
Alexandre Julliard
julliard(a)winehq.org

resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars

[Jens Collin]

Hi Alexandre,

thanks for taking the time to review the patch.
I'm very new to working with multibyte charsets overall, so I'd be happy
if you could complete this or hint me what to change.

Thanks in advance,
Jens 

-----Original Message-----
From: wine-devel-admin(a)winehq.org [mailto:wine-devel-admin(a)winehq.org]
On Behalf Of Alexandre Julliard
Sent: den 10 september 2004 22:22
To: Jens Collin
Cc: wine-devel(a)winehq.org
Subject: Re: resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars


"Jens Collin" <jens.collin(a)lakhei.com> writes:
> +			{
> +				TRACE("The env. var can't be found or is
> bigger than MAX_PATH => useless.");
> +				res += sprintfW(res, L"%s%%",
> tmpBuffer);

You cannot use Unicode strings constants in Wine, they don't have the
right size.

-- 
Alexandre Julliard
julliard(a)winehq.org

resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars

[James Hawkins]

What you need is this:

static const WCHAR nameOfVarW = {'%','s','%','%',0};

and then use nameOfVarW wherever you wanted L"%s%%".


On Sat, 11 Sep 2004 19:42:32 +0200, Jens Collin <jens.collin(a)lakhei.com> wrote:
> Hi Alexandre,
>
> thanks for taking the time to review the patch.
> I'm very new to working with multibyte charsets overall, so I'd be happy
> if you could complete this or hint me what to change.
>
> Thanks in advance,
> Jens
>
> -----Original Message-----
> From: wine-devel-admin(a)winehq.org [mailto:wine-devel-admin(a)winehq.org]
> On Behalf Of Alexandre Julliard
> Sent: den 10 september 2004 22:22
> To: Jens Collin
> Cc: wine-devel(a)winehq.org
> Subject: Re: resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars
>
> "Jens Collin" <jens.collin(a)lakhei.com> writes:
> > +                     {
> > +                             TRACE("The env. var can't be found or is
> > bigger than MAX_PATH => useless.");
> > +                             res += sprintfW(res, L"%s%%",
> > tmpBuffer);
>
> You cannot use Unicode strings constants in Wine, they don't have the
> right size.
>
> --
> Alexandre Julliard
> julliard(a)winehq.org

-- 
James Hawkins

resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars

[Jens Collin]

thanks a lot! New patch is on it's way :)

/Jens

-----Original Message-----
From: wine-devel-admin(a)winehq.org [mailto:wine-devel-admin(a)winehq.org]
On Behalf Of James Hawkins
Sent: den 11 september 2004 19:51
To: Jens Collin
Cc: Alexandre Julliard; wine-devel(a)winehq.org
Subject: Re: resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars


What you need is this:

static const WCHAR nameOfVarW = {'%','s','%','%',0};

and then use nameOfVarW wherever you wanted L"%s%%".

resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars

[Mike Hearn]

<advert>

    Check out the NEW! IMPROVED! Wine developer cheatsheet here:

    http://navi.cx/~mike/wine/developer-cheatsheet.html

    Everything you always wanted to know but were too afraid to ask,
    in ONE convenient document!!

</advert>

In particular, it explains how to work with unicode strings in Wine. 
Look for the comments from Francois to see how to convert between A/W 
strings using Win32, I haven't had a chance to merge them in yet.

thanks -mike

Jens Collin wrote:
> thanks a lot! New patch is on it's way :)
>
> /Jens

resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars

[Dimitrie O. Paun]

On Mon, Sep 13, 2004 at 09:44:12AM +0100, Mike Hearn wrote:
> <advert>
>
> Check out the NEW! IMPROVED! Wine developer cheatsheet here:
>
> http://navi.cx/~mike/wine/developer-cheatsheet.html
>
> Everything you always wanted to know but were too afraid to ask,
>    in ONE convenient document!!
>
> </advert>

Cool. I hope you know this will have to end up on WineHQ, under the
Development section, right? :)

-- 
Dimi.

resend: patch: shell32.dll - SHELL_ArgifyW expands env-vars

[Mike Hearn]

> Cool. I hope you know this will have to end up on WineHQ, under the
> Development section, right? :)

That's the plan. It'll be about a month before I can do that though. If 
anybody wants to submit it as a patch against lostwages then go right 
ahead ...