[PATCH] kernel32: Silence FIXME about FIND_FIRST_EX_LARGE_FETCH
This flag is only relevant for performance. Wine will probably never implement it, and no one will care. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- Qt Creator repeatedly calls FindFirstFileExW with flags=0x2. --- dlls/kernel32/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernel32/file.c b/dlls/kernel32/file.c index bd10260acc..bd7ebd1961 100644 --- a/dlls/kernel32/file.c +++ b/dlls/kernel32/file.c @@ -1981,7 +1981,7 @@ HANDLE WINAPI FindFirstFileExW( LPCWSTR filename, FINDEX_INFO_LEVELS level, TRACE("%s %d %p %d %p %x\n", debugstr_w(filename), level, data, search_op, filter, flags); - if (flags != 0) + if (flags & ~FIND_FIRST_EX_LARGE_FETCH) { FIXME("flags not implemented 0x%08x\n", flags ); } -- 2.22.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=55365 Your paranoid android. === debian10 (32 bit report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00438184). Report errors: kernel32:virtual prints too much data (91050 bytes) === debian10 (32 bit Chinese:China report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00438184). Report errors: kernel32:virtual prints too much data (91050 bytes) === debian10 (32 bit WoW report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00438184). Report errors: kernel32:virtual prints too much data (91050 bytes) === debian10 (64 bit WoW report) === kernel32: Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x00438184). Report errors: kernel32:virtual prints too much data (91050 bytes)
participants (2)
-
Alex Henrie -
Marvin