Re: tools/winegcc: support a trailing / in paths to winebuild
Bernhard Loos <bernhardloos(a)googlemail.com> writes:
diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index 284223e..3a7e93a 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -1326,6 +1326,7 @@ int main(int argc, char **argv) { case 'B': str = strdup(option_arg); + if (strendswith(str, "/")) str[strlen(str) - 1] = 0;
Why would you want to append a slash to winebuild? -- Alexandre Julliard julliard(a)winehq.org
On Mon, Aug 22, 2011 at 5:35 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
Bernhard Loos <bernhardloos(a)googlemail.com> writes:
diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index 284223e..3a7e93a 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -1326,6 +1326,7 @@ int main(int argc, char **argv) { case 'B': str = strdup(option_arg); + if (strendswith(str, "/")) str[strlen(str) - 1] = 0;
Why would you want to append a slash to winebuild?
-- Alexandre Julliard julliard(a)winehq.org
Bash autocompletation. If you run winegcc manually, and autocomplete the -B argument to the winebuild dir, you end up with a / at the end. It's kinda hard to figure out, what goes wrong at this point.
That's to be fixed in bash-completion, not winegcc... On Mon, Aug 22, 2011 at 5:31 PM, Bernhard Loos <bernhardloos(a)googlemail.com> wrote:
On Mon, Aug 22, 2011 at 5:35 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
Bernhard Loos <bernhardloos(a)googlemail.com> writes:
diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index 284223e..3a7e93a 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -1326,6 +1326,7 @@ int main(int argc, char **argv) { case 'B': str = strdup(option_arg); + if (strendswith(str, "/")) str[strlen(str) - 1] = 0;
Why would you want to append a slash to winebuild?
-- Alexandre Julliard julliard(a)winehq.org
Bash autocompletation. If you run winegcc manually, and autocomplete the -B argument to the winebuild dir, you end up with a / at the end. It's kinda hard to figure out, what goes wrong at this point.
On Mon, Aug 22, 2011 at 7:02 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote:
That's to be fixed in bash-completion, not winegcc...
Uhm, what's wrong with bash-completation? -B takes a directory as an argument so bash adds a slash during autocomplete, that's ok. gcc itself can also deal with a trailing / for -B, it's kinda suprising, if this breaks in winegcc.
On Mon, Aug 22, 2011 at 07:13:42PM +0200, Bernhard Loos wrote:
On Mon, Aug 22, 2011 at 7:02 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote:
That's to be fixed in bash-completion, not winegcc...
Uhm, what's wrong with bash-completation? -B takes a directory as an argument so bash adds a slash during autocomplete, that's ok. gcc itself can also deal with a trailing / for -B, it's kinda suprising, if this breaks in winegcc.
bash has 'broken' many things by doing that. Traditionally directory paths wouldn't be expected to have a trailing '/'. David -- David Laight: david(a)l8s.co.uk
On Tue, Aug 23, 2011 at 11:20 AM, David Laight <david(a)l8s.co.uk> wrote:
On Mon, Aug 22, 2011 at 07:13:42PM +0200, Bernhard Loos wrote:
On Mon, Aug 22, 2011 at 7:02 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote:
That's to be fixed in bash-completion, not winegcc...
Uhm, what's wrong with bash-completation? -B takes a directory as an argument so bash adds a slash during autocomplete, that's ok. gcc itself can also deal with a trailing / for -B, it's kinda suprising, if this breaks in winegcc.
bash has 'broken' many things by doing that. Traditionally directory paths wouldn't be expected to have a trailing '/'.
David
-- David Laight: david(a)l8s.co.uk
Well, everything else accepts a trailing slash now, so tradition isn't a good argument here. It's higly surprising and non-obviouls to get magic behavior for ./tools/winebuild but not for ./tools/winebuild/ , especially if gcc itself doesn't distinguish between them.
participants (4)
-
Alexandre Julliard -
Bernhard Loos -
David Laight -
Jerome Leclanche