Re: [PATCH] d3dx9_36/tests: Added HLSL test suite. (Try 2)

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4080

Your paranoid android.


=== WXPPROSP3 (32 bit hlsl) ===
hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
No test summary line found

=== W2K3R2SESP2 (32 bit hlsl) ===
hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
No test summary line found

=== WVISTAADM (32 bit hlsl) ===
hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
No test summary line found

=== W2K8SE (32 bit hlsl) ===
hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
No test summary line found

=== W7PRO (32 bit hlsl) ===
hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
No test summary line found

=== W7PROX64 (32 bit hlsl) ===
hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
No test summary line found

=== W7PROX64 (64 bit hlsl) ===
hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
Timeout

[PATCH] d3dx9_36/tests: Added HLSL test suite. (Try 2)

[Jeff Zaroyko]

On Sat, Jul 31, 2010 at 1:21 PM, Marvin <testbot(a)testbot.winehq.org> wrote:
> === WXPPROSP3 (32 bit hlsl) ===
> hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
> No test summary line found
> ...further CreateDevice test failures snipped...

Is the purpose of these tests device creation?  If not, then it
doesn't really make any sense to do:
> ok(SUCCEEDED(hres), "Could not create device, IDirect3D9_CreateDevice returned: %08x\n", hres);

It would make more sense to just test the result of SUCCEEDED(hres)
and then skip the tests if it's not possible to create the device
rather than counting it as a failed test.

Jeff