Re: try2 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice
Guy Albertelli wrote:
Enhance QueryDosDevice test for attempting to return all devices. Add tests for GetVolumeInformationA testing the different root dir formats. --- dlls/kernel32/tests/volume.c | 134 +++++++++++++++++++++++++++++++++++++++++- 1 files changed, 131 insertions(+), 3 deletions(-)
------------------------------------------------------------------------
+ char Root_Dir3[]="C:\\Windows\\System\\"; .. + Root_Dir3[0] = windowsdir[0]; This won't work on all systems as the windows directory can be different (and can be changed during installation). You could use GetSystemDirectory() instead of GetWindowsDirectory() to find out the drive letter and in the same go use the output from GetSystemDirectory() to fill Root_Dir3. As you're actually interested in an existing directory you could even use the output from GetWindowsDirectory() to fill Root_Dir3. -- Cheers, Paul.
On Fri, 2009-04-10 at 08:31 +0200, Paul Vriens wrote:
Guy Albertelli wrote:
Enhance QueryDosDevice test for attempting to return all devices. Add tests for GetVolumeInformationA testing the different root dir formats. --- dlls/kernel32/tests/volume.c | 134 +++++++++++++++++++++++++++++++++++++++++- 1 files changed, 131 insertions(+), 3 deletions(-)
------------------------------------------------------------------------
+ char Root_Dir3[]="C:\\Windows\\System\\"; .. + Root_Dir3[0] = windowsdir[0];
This won't work on all systems as the windows directory can be different (and can be changed during installation).
You could use GetSystemDirectory() instead of GetWindowsDirectory() to find out the drive letter and in the same go use the output from GetSystemDirectory() to fill Root_Dir3.
As you're actually interested in an existing directory you could even use the output from GetWindowsDirectory() to fill Root_Dir3.
You are 100% correct. Will resubmit.
participants (2)
-
Guy Albertelli -
Paul Vriens