Re: [PATCH 4/6] server: Store and return security attributes with extended file attributes (try 5).
Hi, 27.11.2012 00:45, Erich E. Hoover kirjoitti:
This patch adds the ability to store and retrieve the security attributes of a file by turning them into extended file attributes (if available). These attributes are stored in the attribute "user.WINEACL" in the form: <ACE1>;<ACE2>;...;<ACEN> where each ACE takes the form: <Type>,<Flags>,<Mask>,<SID> With this information it is possible to more accurately store the ACL information files, and also allows patch 5 to tell whether it's necessary for an ACL to be inherited by a contained file in a folder.
I don't see the need for an uppercase "WINEACL" in the attribute name, especially since all the examples in e.g. attr(5) are lowercase. Moreover, [1] recommends using application specific namespaces in the attribute name, so IMHO a better attribute name would be "user.wine.acl". </bikeshedding> Thanks for your work on this :) [1] http://www.freedesktop.org/wiki/CommonExtendedAttributes -- Anssi Hannula
On Sun, Dec 2, 2012 at 5:28 PM, Anssi Hannula <anssi.hannula(a)iki.fi> wrote:
... I don't see the need for an uppercase "WINEACL" in the attribute name, especially since all the examples in e.g. attr(5) are lowercase. Moreover, [1] recommends using application specific namespaces in the attribute name, so IMHO a better attribute name would be "user.wine.acl". ...
I copied the form of "user.DOSATTRIB" that I saw from posts about Samba. If you think it makes more sense to call it "user.wine.acl" then I can certainly do that. Erich
03.12.2012 23:13, Erich E. Hoover kirjoitti:
On Sun, Dec 2, 2012 at 5:28 PM, Anssi Hannula <anssi.hannula(a)iki.fi> wrote:
... I don't see the need for an uppercase "WINEACL" in the attribute name, especially since all the examples in e.g. attr(5) are lowercase. Moreover, [1] recommends using application specific namespaces in the attribute name, so IMHO a better attribute name would be "user.wine.acl". ...
I copied the form of "user.DOSATTRIB" that I saw from posts about Samba. If you think it makes more sense to call it "user.wine.acl" then I can certainly do that.
I do, at least. (of course, I'm just a random non-wine dev) -- Anssi Hannula
participants (2)
-
Anssi Hannula -
Erich E. Hoover