questionable code

[Eric Pouech]

still toying with various compilers, here's two new questions (to whom it may 
concern):

**** dlls/gdi/freetype.c line 1467
the test for "(offset < 0)" is always false. I'm not sure changing it into 
"offset == -1" is the right solution.

*** dlls/ole32/hglobalstream.c line 602
the test "if (newPosition.QuadPart < 0)" is always false as QuadPart is unsigned

A+

[Robert Shearman]

Eric Pouech wrote:
> *** dlls/ole32/hglobalstream.c line 602
> the test "if (newPosition.QuadPart < 0)" is always false as QuadPart 
> is unsigned

Before the call to RtlLargeIntegerAdd we need to add a line with:
if ((dlibMove.QuadPart < 0) && (newMove < -dlibMove.QuadPart)) return 
STG_E_INVALIDFUNCTION;

And remove the offending < 0 line.

You can submit a patch for me, or wait until Monday and I'll submit one.

Rob

[Eric Pouech]

> You can submit a patch for me, or wait until Monday and I'll submit one.
> submitted. thx
> A+