[PATCH] msi: Dont error when an ODBC Data Source fails to register

[Alistair Leslie-Hughes]

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
---
 dlls/msi/action.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 55f978cd4c..f6f7ffbcf4 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -6783,10 +6783,7 @@ static UINT ITERATE_InstallODBCDataSource( MSIRECORD *rec, LPVOID param )
     attrs[len + 1] = 0;
 
     if (!SQLConfigDataSourceW(NULL, request, driver, attrs))
-    {
-        ERR("Failed to install SQL data source!\n");
-        r = ERROR_FUNCTION_FAILED;
-    }
+        WARN("Failed to install SQL data source!\n");
 
     uirow = MSI_CreateRecord( 5 );
     MSI_RecordSetStringW( uirow, 1, desc );
-- 
2.23.0.rc1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=55894

Your paranoid android.


=== debian10 (32 bit report) ===

Report errors:
msi:install contains a misplaced todo message for custom

=== debian10 (32 bit Chinese:China report) ===

Report errors:
msi:install contains a misplaced todo message for custom

=== debian10 (32 bit WoW report) ===

Report errors:
msi:install contains a misplaced todo message for custom

=== debian10 (64 bit WoW report) ===

Report errors:
msi:install contains a misplaced todo message for custom

[Hans Leidekker]

Signed-off-by: Hans Leidekker <hans(a)codeweavers.com>