Re: BUG with wine/dlls/ntdll/string.c:_ultoa() ???!!??

[Uwe Bonnes]

> > > > > "Johann" == Johann Messner <johann.messner(a)zid.uni-linz.ac.at> writes:

Johann> Hi there, First: thanks & compliments for your impressive
    Johann> project!!!

    Johann> please check wine/dlls/ntdll/string.c:_ultoa() ... I think there
    Johann> is a bug in it ...

There are for sure more bug...

    Johann> hans

    Johann> ==> this is the path to it in the web cvs:

...

    Johann> ==> this is the source snippet with the patch as suggested ...

Did you test? As no win function is uses, you can easily write a test
programm wrapper, like

static char *_ultoa(...
void main()
{
   char buffer[32];
   printf(" x %d, radix %d, result %s\n",1000,10,_ultoa(1000,buffer,10));
   printf("...
}


The loop decrements p after use, so p needs to be corrected and I would
think that the original version is right.

Bye

-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------