Re: [DSHOW-08] Implementation of IMemAllocator and IMediaSample (REVISED)

[Alexandre Julliard]

Robert Shearman <R.J.Shearman(a)warwick.ac.uk> writes:
> +    struct list * pFreeList;
> +    struct list * pUsedList;

You are not using the list functions the right way; these should be a
struct list, not a struct list *. The rest of the code then gets a lot
cleaner, you don't need any special cases for empty lists etc.

-- 
Alexandre Julliard
julliard(a)winehq.com

[DSHOW-08] Implementation of IMemAllocator and IMediaSample (REVISED)

[Mike Hearn]

Are we allowed to use that file all over wine? Having access to a global
shared linked list implementation would be handy.

On Tue, 2003-09-09 at 20:49, Alexandre Julliard wrote:
> Robert Shearman <R.J.Shearman(a)warwick.ac.uk> writes:
> > +    struct list * pFreeList;
> > +    struct list * pUsedList;
>
> You are not using the list functions the right way; these should be a
> struct list, not a struct list *. The rest of the code then gets a lot
> cleaner, you don't need any special cases for empty lists etc.