Re: [Resend PATCH 2/2] gdi32: Do not fill in the color table if lpvBits is NULL

[H. Verbeet]

On 13/07/07, Jeremy White <jwhite(a)codeweavers.com> wrote:
> ---
>  dlls/gdi32/dib.c |   14 +++++++++++---
>  1 files changed, 11 insertions(+), 3 deletions(-)

The patch mixes tabs and spaces. Also, in general, I don't think we
should include text from MSDN.

[Resend PATCH 2/2] gdi32: Do not fill in the color table iflpvBits is NULL

[Jeremy White]

> The patch mixes tabs and spaces. Also, in general, I don't think we
> should include text from MSDN.

*blush*.  Teach me to edit this on a test machine, without my .vimrc...

I'll tweak the comment, but I felt it was important to motivate
the if statement; I don't feel that it's obvious from the API
why you fill in color sometimes and not others.

Cheers,

Jeremy

p.s.  While I'm coming clean, *another* failure on my part
was to fail to credit Huw; this is mostly his insight.
I provided the clue, and the hopeless failure to get a clean patch in :-/.