Re: cabinent: add a comment about parm passing
On 6/27/07, Jeff Latimer <lats(a)yless4u.com.au> wrote:
Coverity CID 43 Forward_Null is false. This adds a comment explaining the NULL pass is ok.
Why do we need a comment for that? -- James Hawkins
James Hawkins wrote:
On 6/27/07, Jeff Latimer <lats(a)yless4u.com.au> wrote:
Coverity CID 43 Forward_Null is false. This adds a comment explaining the NULL pass is ok. Why do we need a comment for that? Mainly because the logic is a bit difficult. It depends on the length being 0 to terminate the for loop and prevent the null reference. It is not obvious and easily missed the first time through. Wine has a number of things like that and more comments would make it quicker and safer to works with.
Jeff L <lats(a)yless4u.com.au> writes:
Mainly because the logic is a bit difficult. It depends on the length being 0 to terminate the for loop and prevent the null reference. It is not obvious and easily missed the first time through. Wine has a number of things like that and more comments would make it quicker and safer to works with.
No, the proper way is to fix the code so that it's understandable. In this specific case you can get rid of the realloc function, it's useless. -- Alexandre Julliard julliard(a)winehq.org
participants (3)
-
Alexandre Julliard -
James Hawkins -
Jeff L