Re: [12/13] fusion: Sort the list of assemblies built during enumeration.
On Thu, Feb 19, 2009 at 5:06 AM, Hans Leidekker <hans(a)codeweavers.com> wrote:
This hopefully fixes the test failures on Alexandre's machine.
This isn't how it's done on Windows. On Windows, the order is based solely on directory enumeration, which we don't try to match in Wine. The fix is to check for all N results N times, where N is the number of assemblies enumerated. -- James Hawkins
This isn't how it's done on Windows. On Windows, the order is based solely on directory enumeration, which we don't try to match in Wine.
I don't see how it would hurt if we do match the sort order on Windows, even if we achieve it by other means. -Hans
On Thu, Feb 19, 2009 at 1:14 PM, Hans Leidekker <hans(a)codeweavers.com> wrote:
This isn't how it's done on Windows. On Windows, the order is based solely on directory enumeration, which we don't try to match in Wine.
I don't see how it would hurt if we do match the sort order on Windows, even if we achieve it by other means.
The reason it hurts in this case is because the sorting happens at the File/Directory API level and not in fusion itself. If the same logic applies, why don't we match sorting at that level in Wine? -- James Hawkins
On Thursday 19 February 2009 22:36:25 James Hawkins wrote:
I don't see how it would hurt if we do match the sort order on Windows, even if we achieve it by other means.
The reason it hurts in this case is because the sorting happens at the File/Directory API level and not in fusion itself. If the same logic applies, why don't we match sorting at that level in Wine?
It would hurt overall performance if we do it at the directory API level, so the same logic does not apply. -Hans
On Thu, Feb 19, 2009 at 11:30 PM, Hans Leidekker <hans(a)codeweavers.com> wrote:
On Thursday 19 February 2009 22:36:25 James Hawkins wrote:
I don't see how it would hurt if we do match the sort order on Windows, even if we achieve it by other means.
The reason it hurts in this case is because the sorting happens at the File/Directory API level and not in fusion itself. If the same logic applies, why don't we match sorting at that level in Wine?
It would hurt overall performance if we do it at the directory API level, so the same logic does not apply.
I'm not advocating adding it to the directory API. I'm saying if we don't care about it at that level, then we shouldn't care about it in fusion, and we certainly shouldn't add that functionality to fusion where it doesn't exist in native fusion. -- James Hawkins
On Friday 20 February 2009 08:38:09 James Hawkins wrote:
It would hurt overall performance if we do it at the directory API level, so the same logic does not apply.
I'm not advocating adding it to the directory API. I'm saying if we don't care about it at that level, then we shouldn't care about it in fusion, and we certainly shouldn't add that functionality to fusion where it doesn't exist in native fusion.
Where that functionality exists in Windows is an implementation detail, we don't have to copy that. -Hans
2009/2/20 Hans Leidekker <hans(a)codeweavers.com>:
On Friday 20 February 2009 08:38:09 James Hawkins wrote:
It would hurt overall performance if we do it at the directory API level, so the same logic does not apply.
I'm not advocating adding it to the directory API. I'm saying if we don't care about it at that level, then we shouldn't care about it in fusion, and we certainly shouldn't add that functionality to fusion where it doesn't exist in native fusion.
Where that functionality exists in Windows is an implementation detail, we don't have to copy that.
I don't know the details, but this is not the mentality of Wine. The problem is if some application expects a particular behaviour, that behaviour needs to be replicated in Wine. Binary compatibility is important, so Wine tries to be bug-for-bug compatible. This might be off-topic for this thread, but I feel it is relevant. Feel free to ignore or correct me if I'm wrong here.
participants (3)
-
Ben Klein -
Hans Leidekker -
James Hawkins