Re: joy.cpl: Correct joystick testing thread behavior

[Alexandre Julliard]

Lucas Zawacki <lfzawacki(a)gmail.com> writes:
> @@ -419,14 +421,19 @@ static INT_PTR CALLBACK test_dlgproc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM
>                          SendDlgItemMessageW(hwnd, IDC_TESTSELECTCOMBO, CB_SETCURSEL, 0, 0);
>                          test_handle_joychange(hwnd, data);
>
> -                        thread = CreateThread(NULL, 0, input_thread, (void*) data, 0, &tid);
> +                        ResumeThread(thread);
>                      }
>                  }
>                  break;
>
> +                case PSN_KILLACTIVE:
> +                    SuspendThread(thread);
> +                break;

You never want to use SuspendThread, it can't possibly work reliably.

-- 
Alexandre Julliard
julliard(a)winehq.org