Re: enhmfdrv: Return proper values from GDI APIs

[Phil Krylov]

Hi,

Are there any problems to apply this patch before 0.9?

On Mon, 17 Oct 2005 03:43:55 +0400
Phil Krylov <phil(a)newstar.rinet.ru> wrote:
> Hi,
>
> This patch fixes EMF rendering in some programs that depend on the fact
> that SetTextAlign(), SetBkMode(), SetROP2(), SetPolyFillMode(), and
> SetStretchBltMode() return proper values when called on a EMF device
> context.
>
> ChangeLog:
>
> Fixed EMFDRV_SetTextAlign, EMFDRV_SetBkMode, EMFDRV_SetROP2,
> EMFDRV_SetPolyFillMode, and EMFDRV_SetStretchBltMode to return proper
> old values of modes that are being set. Added FIXMEs for other cases of
> improper return values.
>
> -- Ph.

-- Ph.

enhmfdrv: Return proper values from GDI APIs

[Huw D M Davies]

Writing some tests would probably help.

Huw.

On Fri, Oct 21, 2005 at 05:57:58PM +0400, Phil Krylov wrote:
> Hi,
>
> Are there any problems to apply this patch before 0.9?
>
> On Mon, 17 Oct 2005 03:43:55 +0400
> Phil Krylov <phil(a)newstar.rinet.ru> wrote:
> > Hi,
> >
> > This patch fixes EMF rendering in some programs that depend on the fact
> > that SetTextAlign(), SetBkMode(), SetROP2(), SetPolyFillMode(), and
> > SetStretchBltMode() return proper values when called on a EMF device
> > context.
> >
> > ChangeLog:
> >
> > Fixed EMFDRV_SetTextAlign, EMFDRV_SetBkMode, EMFDRV_SetROP2,
> > EMFDRV_SetPolyFillMode, and EMFDRV_SetStretchBltMode to return proper
> > old values of modes that are being set. Added FIXMEs for other cases of
> > improper return values.
> >
> > -- Ph.
>
> -- Ph.

-- 
Huw Davies
huw(a)codeweavers.com

enhmfdrv: Return proper values from GDI APIs

[Alexandre Julliard]

Phil Krylov <phil(a)newstar.rinet.ru> writes:
> Are there any problems to apply this patch before 0.9?

I think it would be cleaner to simply fall through to the generic code
after calling the driver for these operations. Also there's no need to
add a FIXME on every single operation, this will cause a lot of noise,
a comment should be enough.

-- 
Alexandre Julliard
julliard(a)winehq.org

enhmfdrv: Return proper values from GDI APIs

[Phil Krylov]

On Fri, 21 Oct 2005 16:14:25 +0200
Alexandre Julliard <julliard(a)winehq.org> wrote:
> I think it would be cleaner to simply fall through to the generic code
> after calling the driver for these operations. Also there's no need to
> add a FIXME on every single operation, this will cause a lot of noise,
> a comment should be enough.

Thanks, I've just sent an updated patch to wine-patches.

-- Ph.