Re: TestBot job 83503 results: [PATCH] ws2_32: Fix buffer size check in WSAIoctl() for SIO_GET_INTERFACE_LIST.

[Paul Gofman]

On 12/16/20 12:10, Marvin wrote:
> ws2_32:
> sock.c:10534: Test failed: Got unexpected ret 0.
> sock.c:10535: Test failed: Got unexpected error 6.
> sock.c:10536: Test failed: Got unexpected size 76.

Can it be that Wine is not getting updated on Testbot? The tests results
are like the changes to test are applied but ws2_32.dll is unchanged.

TestBot job 83503 results: [PATCH] ws2_32: Fix buffer size check in WSAIoctl() for SIO_GET_INTERFACE_LIST.

[Francois Gouget]

On Wed, 16 Dec 2020, Paul Gofman wrote:
> On 12/16/20 12:10, Marvin wrote:
> > ws2_32:
> > sock.c:10534: Test failed: Got unexpected ret 0.
> > sock.c:10535: Test failed: Got unexpected error 6.
> > sock.c:10536: Test failed: Got unexpected size 76.
>
> Can it be that Wine is not getting updated on Testbot? The tests results
> are like the changes to test are applied but ws2_32.dll is unchanged.

The "Show full task log" links show that ws2_32.dll.so was rebuilt.

https://testbot.winehq.org/JobDetails.pl?Key=83503&f401=task.log#k401
https://testbot.winehq.org/JobDetails.pl?Key=83503&f402=task.log#k402

Also, as far as I can tell, the WinePrefix only contains a fake dll so 
it does not look like there any way the WinePrefix could use an old 
version.

-- 
Francois Gouget <fgouget(a)codeweavers.com>

TestBot job 83503 results: [PATCH] ws2_32: Fix buffer size check in WSAIoctl() for SIO_GET_INTERFACE_LIST.

[Paul Gofman]

On 12/17/20 12:25, Francois Gouget wrote:
> On Wed, 16 Dec 2020, Paul Gofman wrote:
> > On 12/16/20 12:10, Marvin wrote:
> > > ws2_32:
> > > sock.c:10534: Test failed: Got unexpected ret 0.
> > > sock.c:10535: Test failed: Got unexpected error 6.
> > > sock.c:10536: Test failed: Got unexpected size 76.
> > > Can it be that Wine is not getting updated on Testbot? The tests results
> > > are like the changes to test are applied but ws2_32.dll is unchanged.
> > > The "Show full task log" links show that ws2_32.dll.so was rebuilt.
>
> https://testbot.winehq.org/JobDetails.pl?Key=83503&f401=task.log#k401
> https://testbot.winehq.org/JobDetails.pl?Key=83503&f402=task.log#k402
>
> Also, as far as I can tell, the WinePrefix only contains a fake dll so 
> it does not look like there any way the WinePrefix could use an old 
> version.

Yeah, indeed, and I figured that the failure is still there with the
dummy patch after that patch was committed. That happens because
WSAIoctl(...,SIO_GET_INTERFACE_LIST,...) finds just one appropriate
interface which I honestly didn't expect. I've sent the patch which will
avoid such test failure, but I am still curious how that can happen, I
was under impression that at least loopback should be available besides
the "normal" interface on Testbot. Maybe that indicates some issue in
ws2_32 SIO_GET_INTERFACE_LIST or iphlpapi. Is it possible to see the
output of 'ifconfig' from debiant?

TestBot job 83503 results: [PATCH] ws2_32: Fix buffer size check in WSAIoctl() for SIO_GET_INTERFACE_LIST.

[Francois Gouget]

On Thu, 17 Dec 2020, Paul Gofman wrote:
[...]
> Is it possible to see the output of 'ifconfig' from debiant? 

You can't because it's not installed. But this should do:


diff --git a/Makefile.in b/Makefile.in
index b52495f741f..e07b8c39fab 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -91,6 +91,7 @@ TOP_INSTALL_DEV     = @TOP_INSTALL_DEV@
 
 all: wine
 	@echo "Wine build complete."
+	ip address
 
 # Rules for re-running configure
 
diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c
index 98cc3881853..5d28df13498 100644
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -1,4 +1,4 @@
-/*
+/* Dummy
  * Unit test suite for winsock functions
  *
  * Copyright 2002 Martin Wilck


-- 
Francois Gouget <fgouget(a)codeweavers.com>

TestBot job 83503 results: [PATCH] ws2_32: Fix buffer size check in WSAIoctl() for SIO_GET_INTERFACE_LIST.

[Paul Gofman]

Thanks. Yes, there are two problems with SIO_GET_INTERFACE_LIST:

- It doesn't report loopback interface while it should (as
GetAdaptersInfo() does not report it by design; I guess GetIpAddrTable()
should be used instead);
- There is a check to skip unconfigured interfaces with zero address,
and the check is wrong (checks for '\0' char instead of '0'), so
intrefaces with zero IP addresses are still returned.

But fixes for these should probably wait until the code freeze end.

On 12/17/20 13:40, Francois Gouget wrote:
> On Thu, 17 Dec 2020, Paul Gofman wrote:
> [...]
> > Is it possible to see the output of 'ifconfig' from debiant? 
> > You can't because it's not installed. But this should do:
>
> diff --git a/Makefile.in b/Makefile.in
> index b52495f741f..e07b8c39fab 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -91,6 +91,7 @@ TOP_INSTALL_DEV     = @TOP_INSTALL_DEV@
>
> all: wine
>   @echo "Wine build complete."
> +	ip address
>
> # Rules for re-running configure
>
> diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c
> index 98cc3881853..5d28df13498 100644
> --- a/dlls/ws2_32/tests/sock.c
> +++ b/dlls/ws2_32/tests/sock.c
> @@ -1,4 +1,4 @@
> -/*
> +/* Dummy
>   * Unit test suite for winsock functions
>   *
>   * Copyright 2002 Martin Wilck