[PATCH] winex11.drv: Add missing Vulkan extensions.

[Giovanni Mascellani]

They were flagged by validation layers as required:
VK_EXT_direct_mode_display depends on VK_KHR_display and transitively
on VK_KHR_surface. VK_KHR_external_fence_capabilities is required by
VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_ID_PROPERTIES.

Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com>
---
 dlls/winex11.drv/xrandr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/winex11.drv/xrandr.c b/dlls/winex11.drv/xrandr.c
index fa748c2af04..cf4683571bc 100644
--- a/dlls/winex11.drv/xrandr.c
+++ b/dlls/winex11.drv/xrandr.c
@@ -598,6 +598,9 @@ static BOOL get_gpu_properties_from_vulkan( struct x11drv_gpu *gpu, const XRRPro
         VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME,
         "VK_EXT_acquire_xlib_display",
         "VK_EXT_direct_mode_display",
+        "VK_KHR_display",
+        "VK_KHR_surface",
+        "VK_KHR_external_fence_capabilities",
     };
     const struct vulkan_funcs *vulkan_funcs = get_vulkan_driver( WINE_VULKAN_DRIVER_VERSION );
     VkResult (*pvkGetRandROutputDisplayEXT)( VkPhysicalDevice, Display *, RROutput, VkDisplayKHR * );
-- 
2.30.0

[Zhiyi Zhang]

On 2/10/21 11:17 PM, Giovanni Mascellani wrote:
> They were flagged by validation layers as required:
> VK_EXT_direct_mode_display depends on VK_KHR_display and transitively
> on VK_KHR_surface. VK_KHR_external_fence_capabilities is required by
> VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_ID_PROPERTIES.
>
> Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com>
> ---
>  dlls/winex11.drv/xrandr.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/dlls/winex11.drv/xrandr.c b/dlls/winex11.drv/xrandr.c
> index fa748c2af04..cf4683571bc 100644
> --- a/dlls/winex11.drv/xrandr.c
> +++ b/dlls/winex11.drv/xrandr.c
> @@ -598,6 +598,9 @@ static BOOL get_gpu_properties_from_vulkan( struct x11drv_gpu *gpu, const XRRPro
>          VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME,
>          "VK_EXT_acquire_xlib_display",
>          "VK_EXT_direct_mode_display",
> +        "VK_KHR_display",
> +        "VK_KHR_surface",
> +        "VK_KHR_external_fence_capabilities",
> VK_KHR_external_fence_capabilities is probably a false positive. See https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2457
> };
>      const struct vulkan_funcs *vulkan_funcs = get_vulkan_driver( WINE_VULKAN_DRIVER_VERSION );
>      VkResult (*pvkGetRandROutputDisplayEXT)( VkPhysicalDevice, Display *, RROutput, VkDisplayKHR * );

[Giovanni Mascellani]

Hi,

Il 10/02/21 16:47, Zhiyi Zhang ha scritto:
> VK_KHR_external_fence_capabilities is probably a false positive. Seehttps://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2457

Thanks for the pointer, but still it seems that at least one 
between|||VK_KHR_external_memory_capabilities, 
VK_KHR_external_semaphore_capabilities and 
VK_KHR_external_fence_capabilities is required[1]. Am I missing anything?
|

|[1] 
https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkPhysicalDeviceIDProperties.html|

|Giovanni.
|

||